Review main Merged

76460[BUGFIX] Keep existing baseVariants for site languages

Benni Mack CR +2 V +2 Normal +85 −6 updated 11/09/22, 08:11

Commit message

The backend UI does not support handling of baseVariants
for languages, however it is possible to define them
in the config.yaml of a site configuration.

However, when editing and saving a site, the baseVariants
manually defined were removed. This has now been changed,
as the baseVariants are kept when persisting
the site configuratino via the UI.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Benni Mack uploaded patch set 1 11/07/22, 21:40

  2. core-ci voted on patch set 1 V +1 11/07/22, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33226

  3. Stefan Bürk commented on patch set 2 11/07/22, 22:26

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 11/07/22, 22:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33232

  5. Stefan Bürk commented on patch set 2 CR -1 11/08/22, 12:26

    on it
  6. Stefan Bürk uploaded patch set 3 11/08/22, 12:29

  7. core-ci voted on patch set 3 V +1 11/08/22, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33301

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 11/08/22, 12:39

  9. Oli Bartsch commented on patch set 3 CR -1 11/08/22, 17:48

    reviewing..
  10. Oli Bartsch uploaded patch set 4 11/08/22, 21:28

  11. core-ci voted on patch set 4 V +1 11/08/22, 21:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33359

  12. Stefan Bürk voted on patch set 4 V +1 CR +1 11/08/22, 21:40

  13. Oli Bartsch voted on patch set 4 V +1 CR +1 11/08/22, 21:40

  14. Benni Mack voted on patch set 4 V +2 CR +2 11/09/22, 08:11

  15. Benni Mack merged patch set 5 11/09/22, 08:11