Review main Merged

76461[FOLLOWUP][BUGFIX] Prevent out of bounds exception in password generation

Oli Bartsch CR +2 V +2 Normal +162 −8 updated 11/08/22, 08:40

Commit message

This followup prevents an out of bounds exception and
adds a couple of tests for the new functionality.

The min length is now set to 8. This is now also checked
when using the special "random" option.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 78

  1. Oli Bartsch uploaded patch set 1 11/07/22, 22:24

  2. Benni Mack voted on patch set 1 CR +1 11/07/22, 22:30

  3. core-ci voted on patch set 1 V +1 11/07/22, 22:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33231

  4. Georg Ringer voted on patch set 1 V +1 CR +1 11/08/22, 06:56

  5. Christian Kuhn voted on patch set 1 V +1 11/08/22, 08:18

  6. Oliver Hader voted on patch set 1 CR +1 11/08/22, 08:40

  7. Oli Bartsch voted on patch set 1 V +2 CR +2 11/08/22, 08:40

  8. Oli Bartsch merged patch set 2 11/08/22, 08:40