Review main Merged

76474[TASK] Deprecate ext_emconf.php clearCacheOnLoad

Christian Kuhn CR +2 V +2 Normal +46 −43 updated 11/08/22, 13:32

Commit message

There is little point in not clearing all caches
when extensions are loaded / unloaded using
the extension manager. It's easier for extension
developers to rely on all caches being cleared,
it's one thing less to think about.

The patch deprecates the clearCacheOnLoad and
clearcacheonload array key in ext_emconf.php
and removes the handling in extension manager.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1012

  1. Christian Kuhn uploaded patch set 1 11/08/22, 11:16

  2. Oliver Klee commented on patch set 1 11/08/22, 11:22

    InstallUtilityTest.php:157

    While we're changing these lines anyway, we can now remove those for the tests where the cache flushing is not part of the statement about the tested behavior. (With PHPUnit mocks, this is possible, while with Prophecy it was not.) Ditto for the other tests except installCallsFlushCaches.
  3. core-ci voted on patch set 1 V +1 11/08/22, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33293

  4. Christian Kuhn uploaded patch set 2 11/08/22, 11:24

  5. Christian Kuhn commented on patch set 2 11/08/22, 11:24

    InstallUtilityTest.php:157 Reply

    Done
  6. Oliver Klee voted on patch set 2 CR +1 11/08/22, 11:32

  7. core-ci voted on patch set 2 V +1 11/08/22, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33294

  8. Stefan Bürk voted on patch set 2 V +1 CR +1 11/08/22, 12:03

  9. Benni Mack voted on patch set 2 V +2 CR +2 11/08/22, 12:22

  10. Benni Mack merged patch set 3 11/08/22, 12:22

  11. Stephan Großberndt commented on patch set 3 11/08/22, 13:19

    InstallUtility.php:148

    No longer true
  12. Christian Kuhn commented on patch set 3 11/08/22, 13:32