Review main Merged

76477[TASK] Actively deprecate TypoScript TemplateService

Christian Kuhn CR +2 V +2 Normal +103 −10 updated 11/08/22, 19:37

Commit message

With last non-b/w compatibility related calls to
TypoScript/TemplateService being removed, we can
now actively deprecate method usages of this class.

The deprecation has been mentioned with v12.0 in
Breaking-97816-NewTypoScriptParserInFrontend.rst
already, the patch adds trigger_error() calls and
streamlines some left over comments. Another
ReST file is added pointing to the new Request
attribute added in Frontend context.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 11

Review log 1013

  1. Christian Kuhn uploaded patch set 1 11/08/22, 12:24

  2. Christian Kuhn updated the commit message in patch set 2 11/08/22, 12:27

  3. Benni Mack commented on patch set 2 CR -1 11/08/22, 12:32

    RST file missing (please also add a description on how to parse TypoScript with the new way, if that is possible)
  4. core-ci voted on patch set 1 V +1 11/08/22, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33299

  5. Christian Kuhn commented on patch set 2 CR -1 11/08/22, 12:36

    Reply

    ok, will try to come up with a dedicated .rst file for this.
  6. core-ci voted on patch set 2 V +1 11/08/22, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33300

  7. Christian Kuhn uploaded patch set 3 11/08/22, 12:50

  8. Christian Kuhn uploaded patch set 4 11/08/22, 12:52

  9. Christian Kuhn updated the commit message in patch set 5 11/08/22, 12:54

  10. core-ci voted on patch set 5 V +1 11/08/22, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33306

  11. Benni Mack voted on patch set 5 V +1 CR +1 11/08/22, 18:05

  12. Stefan Bürk voted on patch set 5 V +2 CR +2 11/08/22, 19:37

  13. Stefan Bürk merged patch set 6 11/08/22, 19:37