76481[BUGFIX] Ensure proper encapsulation of comparisons with QueryBuilder
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Susi Moog +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Susi Moog +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php+102 −9
- typo3/sysext/core/Classes/Database/Query/Expression/CompositeExpression.php+1 −1
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/DefaultRestrictionContainerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/EndTimeRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendGroupRestrictionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendRestrictionContainerTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/LimitToTablesRestrictionContainerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/PagePermissionRestrictionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/WorkspaceRestrictionTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+9 −9
- typo3/sysext/core/Tests/UnitDeprecated/Database/Query/Restriction/BackendWorkspaceRestrictionTest.php+4 −4
- typo3/sysext/core/Tests/UnitDeprecated/Database/Query/Restriction/FrontendWorkspaceRestrictionTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+75 −9
Review log 2029
Show 4 earlier messages
-
core-ci voted on patch set 1 V -1 11/08/22, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33310
-
Stefan Bürk commented on patch set 1 11/08/22, 13:36
BackendUtility.php:277ReplyDone -
core-ci voted on patch set 2 V -1 11/08/22, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33312
-
Oliver Klee commented on patch set 2 11/08/22, 13:53
BackendUtility.php:277ReplyDone -
Stefan Bürk commented on patch set 2 11/08/22, 14:22
Reply
Thanks. Still WIP - commit message will be adopted after overworking the patch is finished. -
Oliver Klee wrote 11/08/22, 14:29
Removed reviewer Oliver Klee. -
Stefan Bürk uploaded patch set 3 11/08/22, 17:53
-
core-ci voted on patch set 3 V -1 11/08/22, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33329
-
Stefan Bürk uploaded patch set 4 11/08/22, 18:17
-
core-ci voted on patch set 4 V -1 11/08/22, 18:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33338
-
Stefan Bürk uploaded patch set 5 11/08/22, 18:52
-
core-ci voted on patch set 5 V +1 11/08/22, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33341
-
Stefan Bürk uploaded patch set 6 11/08/22, 19:17
-
core-ci voted on patch set 6 V -1 11/08/22, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33342
-
Stefan Bürk updated the commit message in patch set 7 11/08/22, 19:25
-
Stefan Bürk uploaded patch set 8 11/08/22, 19:26
-
core-ci voted on patch set 7 V -1 11/08/22, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33344
-
Stefan Bürk updated the commit message in patch set 9 11/08/22, 19:27
-
core-ci voted on patch set 9 V +1 11/08/22, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33346
-
Oliver Klee updated the commit message in patch set 10 11/08/22, 19:50
-
core-ci voted on patch set 10 V +1 11/08/22, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33353
-
Benni Mack voted on patch set 10 V +1 CR +1 11/08/22, 21:30
-
Susi Moog voted on patch set 10 V +1 CR +1 11/09/22, 08:23
-
Stefan Bürk voted on patch set 10 V +2 CR +2 11/09/22, 08:55
-
Stefan Bürk merged patch set 11 11/09/22, 08:55
BackendUtility.php:277