Review main Merged

76481[BUGFIX] Ensure proper encapsulation of comparisons with QueryBuilder

Stefan Bürk CR +2 V +2 Hard +225 −66 updated 11/09/22, 08:55

Commit message

When using a TCA table without deleted, or any other enablefields
except "endtime", then the SQL query is built in a wrong fashion
both in PageRepository and BackendUtility. Thee source of this disaster
is inproper encapsulation in parenthesis when comparisons are build.

Instead of simply adding a manual "()" around the or() comparisons,
this change adjusts CompositionExpresion to properly add corresponding
parenthesis, which ensure this in every case and avoid missing usages.

A couple of tests are adjusted to properly reflect this change.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 2029

Show 4 earlier messages
  1. Stefan Bürk uploaded patch set 1 11/08/22, 13:31

  2. Oliver Klee commented on patch set 1 CR -1 11/08/22, 13:32

    BackendUtility.php:277

    Debug code, begone!
  3. Andreas Kienast commented on patch set 1 11/08/22, 13:34

    main

    BackendUtility.php:277

    Left-over debug code
  4. Stefan Bürk uploaded patch set 2 11/08/22, 13:35

  1. core-ci voted on patch set 1 V -1 11/08/22, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33310

  2. Stefan Bürk commented on patch set 1 11/08/22, 13:36

    BackendUtility.php:277 Reply

    Done
  3. core-ci voted on patch set 2 V -1 11/08/22, 13:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33312

  4. Oliver Klee commented on patch set 2 11/08/22, 13:53

    BackendUtility.php:277 Reply

    Done
  5. Stefan Bürk commented on patch set 2 11/08/22, 14:22

    Reply

    Thanks. Still WIP - commit message will be adopted after overworking the patch is finished.
  6. Oliver Klee wrote 11/08/22, 14:29

    Removed reviewer Oliver Klee.
  7. Stefan Bürk uploaded patch set 3 11/08/22, 17:53

  8. core-ci voted on patch set 3 V -1 11/08/22, 18:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33329

  9. Stefan Bürk uploaded patch set 4 11/08/22, 18:17

  10. core-ci voted on patch set 4 V -1 11/08/22, 18:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33338

  11. Stefan Bürk uploaded patch set 5 11/08/22, 18:52

  12. core-ci voted on patch set 5 V +1 11/08/22, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33341

  13. Stefan Bürk uploaded patch set 6 11/08/22, 19:17

  14. core-ci voted on patch set 6 V -1 11/08/22, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33342

  15. Stefan Bürk updated the commit message in patch set 7 11/08/22, 19:25

  16. Stefan Bürk uploaded patch set 8 11/08/22, 19:26

  17. core-ci voted on patch set 7 V -1 11/08/22, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33344

  18. Stefan Bürk updated the commit message in patch set 9 11/08/22, 19:27

  19. core-ci voted on patch set 9 V +1 11/08/22, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33346

  20. Oliver Klee updated the commit message in patch set 10 11/08/22, 19:50

  21. core-ci voted on patch set 10 V +1 11/08/22, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33353

  22. Benni Mack voted on patch set 10 V +1 CR +1 11/08/22, 21:30

  23. Susi Moog voted on patch set 10 V +1 CR +1 11/09/22, 08:23

  24. Stefan Bürk voted on patch set 10 V +2 CR +2 11/09/22, 08:55

  25. Stefan Bürk merged patch set 11 11/09/22, 08:55