76483[FEATURE] Add tile view to filelist
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 25
- Build/Sources/Sass/component/_resources.scssnew+176 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/backend/drag-uploader.ts+15 −15
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/core/Classes/Resource/Utility/ListUtility.php+22 −12
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-99155-AddTileViewToFilelist.rstnew+36 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+6 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+5 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileMetaDataCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+6 −5
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+13 −6
- typo3/sysext/filelist/Classes/Controller/FileListController.php+33 −15
- typo3/sysext/filelist/Classes/Dto/PaginationLink.phpnew+30 −0
- typo3/sysext/filelist/Classes/Dto/ResourceCollection.phpnew+182 −0
- typo3/sysext/filelist/Classes/Dto/ResourceView.phpnew+159 −0
- typo3/sysext/filelist/Classes/Dto/UserPermissions.phpnew+29 −0
- typo3/sysext/filelist/Classes/Pagination/ResourceCollectionPaginator.phpnew+61 −0
- typo3/sysext/filelist/Classes/Type/NavigationDirection.phpnew+27 −0
- typo3/sysext/filelist/Classes/Type/ViewMode.phpnew+27 −0
Show 5 more files
- typo3/sysext/filelist/Classes/FileList.php3+381 −393
- typo3/sysext/filelist/Configuration/Backend/Modules.php+2 −0
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+40 −44
- typo3/sysext/filelist/Resources/Private/Templates/Filelist/List.htmlnew+6 −0
- typo3/sysext/filelist/Resources/Private/Templates/Filelist/Tiles.htmlnew+88 −0
Review log 61106
Show 4281 earlier messages
-
Benjamin Kott uploaded patch set 1 11/08/22, 13:47
-
core-ci voted on patch set 1 V -1 11/08/22, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33314
-
Benjamin Kott uploaded patch set 2 11/09/22, 07:11
-
Benjamin Kott uploaded patch set 3 11/09/22, 07:21
-
core-ci voted on patch set 2 V -1 11/09/22, 07:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33368
-
core-ci voted on patch set 3 V -1 11/09/22, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33369
-
Benjamin Kott uploaded patch set 4 11/09/22, 10:49
-
core-ci voted on patch set 4 V -1 11/09/22, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33394
-
Benjamin Kott uploaded patch set 5 11/09/22, 11:45
-
core-ci voted on patch set 5 V -1 11/09/22, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33397
-
Benjamin Kott uploaded patch set 6 11/10/22, 10:24
-
core-ci voted on patch set 6 V -1 11/10/22, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33451
-
Benjamin Kott uploaded patch set 7 11/10/22, 13:57
-
core-ci voted on patch set 7 V -1 11/10/22, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33495
-
Benjamin Kott uploaded patch set 8 11/10/22, 14:37
-
core-ci voted on patch set 8 V -1 11/10/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33499
-
Benjamin Kott uploaded patch set 9 11/10/22, 15:40
-
core-ci voted on patch set 9 V -1 11/10/22, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33510
-
Benjamin Kott uploaded patch set 10 11/11/22, 10:28
-
core-ci voted on patch set 10 V -1 11/11/22, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33561
-
Benjamin Kott uploaded patch set 11 11/11/22, 12:08
-
core-ci voted on patch set 11 V -1 11/11/22, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33576
-
Benjamin Kott uploaded patch set 12 11/11/22, 15:32
-
core-ci voted on patch set 12 V -1 11/11/22, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33596
-
Benjamin Kott uploaded patch set 13 11/11/22, 16:01
-
core-ci voted on patch set 13 V -1 11/11/22, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33598
-
Josef Glatz updated the commit message in patch set 14 11/14/22, 05:39
-
core-ci voted on patch set 14 V -1 11/14/22, 05:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33684
-
Benjamin Kott uploaded patch set 15 11/14/22, 09:02
-
core-ci voted on patch set 15 V -1 11/14/22, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33690
-
Benjamin Kott uploaded patch set 16 11/14/22, 11:09
-
core-ci voted on patch set 16 V -1 11/14/22, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33697
-
Benjamin Kott uploaded patch set 17 11/15/22, 07:16
-
core-ci voted on patch set 17 V -1 11/15/22, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33733
-
Josef Glatz updated the commit message in patch set 18 11/15/22, 10:34
-
core-ci voted on patch set 18 V -1 11/15/22, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33744
-
Benjamin Kott uploaded patch set 19 11/16/22, 08:20
-
Benjamin Kott uploaded patch set 20 11/16/22, 08:21
-
core-ci voted on patch set 19 V -1 11/16/22, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33809
-
core-ci voted on patch set 20 V -1 11/16/22, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33810
-
Benjamin Kott uploaded patch set 21 11/16/22, 09:22
-
core-ci voted on patch set 21 V -1 11/16/22, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33813
-
Benjamin Kott uploaded patch set 22 11/16/22, 09:42
-
core-ci voted on patch set 22 V -1 11/16/22, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33817
-
Benjamin Kott uploaded patch set 23 11/16/22, 12:03
-
core-ci voted on patch set 23 V -1 11/16/22, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33823
-
Benjamin Kott uploaded patch set 24 11/17/22, 09:36
-
core-ci voted on patch set 24 V -1 11/17/22, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33859
-
Benjamin Kott uploaded patch set 25 11/17/22, 14:04
-
core-ci voted on patch set 25 V -1 11/17/22, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33871
-
Benjamin Kott uploaded patch set 26 11/17/22, 14:39
-
core-ci voted on patch set 26 V -1 11/17/22, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33874
-
Benjamin Kott uploaded patch set 27 11/17/22, 15:44
-
core-ci voted on patch set 27 V -1 11/17/22, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33878
-
Benjamin Kott rebased onto patch set 28 11/18/22, 08:30
-
core-ci voted on patch set 28 V -1 11/18/22, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33901
-
Benjamin Kott uploaded patch set 29 11/18/22, 12:56
-
core-ci voted on patch set 29 V -1 11/18/22, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33918
-
Benjamin Kott uploaded patch set 30 11/18/22, 14:44
-
core-ci voted on patch set 30 V -1 11/18/22, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33919
-
Benjamin Kott uploaded patch set 31 11/18/22, 15:13
-
Benjamin Kott uploaded patch set 32 11/18/22, 15:26
-
core-ci voted on patch set 31 V -1 11/18/22, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33922
-
core-ci voted on patch set 32 V -1 11/18/22, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33923
-
Benjamin Kott uploaded patch set 33
V -111/21/22, 07:59 -
core-ci voted on patch set 33 V -1 11/21/22, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34027
-
Benjamin Kott uploaded patch set 34
V -111/21/22, 12:48 -
core-ci voted on patch set 34 V -1 11/21/22, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34041
-
Benjamin Kott uploaded patch set 35
V -111/21/22, 13:22 -
core-ci voted on patch set 35 V -1 11/21/22, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34042
-
Benjamin Kott uploaded patch set 36
V -111/21/22, 14:13 -
core-ci voted on patch set 36 V -1 11/21/22, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34043
-
Benjamin Kott uploaded patch set 37
V -111/21/22, 15:01 -
Benjamin Kott uploaded patch set 38 11/21/22, 15:03
-
core-ci voted on patch set 37 V -1 11/21/22, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34044
-
core-ci voted on patch set 38 V -1 11/21/22, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34045
-
Benjamin Kott uploaded patch set 39
V -111/22/22, 11:07 -
core-ci voted on patch set 39 V +1 11/22/22, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34066
-
Benjamin Kott uploaded patch set 40
V +111/22/22, 11:26 -
Benjamin Kott uploaded patch set 41 11/22/22, 11:28
-
Benjamin Kott updated the commit message in patch set 42 11/22/22, 11:29
-
core-ci voted on patch set 40 V +1 11/22/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34067
-
core-ci voted on patch set 41 V +1 11/22/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34068
-
core-ci voted on patch set 42 V +1 11/22/22, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34069
-
Georg Ringer commented on patch set 42 CR +1 11/22/22, 11:53
awesome! some little input: the chechbox is a bit hard to hit as it is rather small and especially because the image is linked it is very hard to check multiple images without triggering a detail link - ideas: clicking the image should trigger the checkbox using a label tag and a separate detail link? - some margin around the checkbox? - always show the checkbox + move it somewhere else so that clicking some pixel around won't trigger an action - kind of safe zone around the checkbox -
Georg Ringer voted on patch set 42 V -1 11/22/22, 11:54
-
Benjamin Kott commented on patch set 42 11/22/22, 12:03
Reply
Hey, I agree that there are more optimizations possible. For now, the focus is to get a workable state in that we can improve and battle test until LTS. There are multiple things missing in this one. - Improve selection on touch devices - Improve multi record selections - Improve selections in general - Improve keyboard selections by hitting space - Check if we can enable multiple selections by dragging the mouse. - Make this view available in the link browser - Improve display of folders, file counter preview of images inside etc - ... The list is not short, think it´s better to get a starter patch in that as mentioned works and has no major drawbacks. So we can focus on little details afterwards. -
Georg Ringer commented on patch set 42 V +1 11/22/22, 12:13
thanks for the detailed answer. changed to a +1 -
Andreas Kienast commented on patch set 42 11/22/22, 13:00
FileList.php:214Could this be private? -
Benjamin Kott commented on patch set 42 11/22/22, 13:03
FileList.php:214Replyyes, should be -
Christian Kuhn commented on patch set 42 CR -1 11/22/22, 13:30
will give this a php-side review soon. -
Benjamin Kott commented on patch set 42 11/22/22, 13:35
Reply
<3 -
Benjamin Kott uploaded patch set 43
CR +1V +111/23/22, 07:03 -
Benjamin Kott commented on patch set 43 CR -1 11/23/22, 07:04
rebase, waiting for code review of lolli -
Benjamin Kott commented on patch set 43 11/23/22, 07:04
FileList.php:214ReplyDone -
core-ci voted on patch set 43 V +1 11/23/22, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34099
-
Benni Mack uploaded patch set 44
CR -1V +111/23/22, 08:56 -
core-ci voted on patch set 44 V +1 11/23/22, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34103
-
Benni Mack uploaded patch set 45
V +111/23/22, 09:05 -
core-ci voted on patch set 45 V +1 11/23/22, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34104
-
Benni Mack voted on patch set 45 V +1 CR +1 11/23/22, 09:15
-
Benni Mack commented on patch set 45 11/23/22, 09:15
Reply
Done -
Andreas Kienast voted on patch set 45 V +1 CR +1 11/23/22, 09:17
-
Frank Nägler voted on patch set 45 V +1 CR +1 11/23/22, 09:30
-
Andreas Kienast voted on patch set 45 V +2 CR +2 11/23/22, 09:32
-
Andreas Kienast merged patch set 46 11/23/22, 09:32