Review main Merged

76483[FEATURE] Add tile view to filelist

Benjamin Kott CR +2 V +2 Expert +1348 −493 updated 11/23/22, 09:32

Commit message

The listing of resources in a table has some specific use
cases but for the editor, hard to get an overview of file
resources since the thumbnails are small.

To provide a better overview of assets in the file module we
are introducing a tile view with bigger thumbnails and reduced
meta information. The user can now choose the desired display
mode of the assets depending on the current requirements.

The user can change the view mode in the view menu in the
module menu bar. By default the tile view is enabled for
new and existing users.

TYPO3 will remember the choice of the user.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 61106

Show 4281 earlier messages
  1. Benjamin Kott uploaded patch set 1 11/08/22, 13:47

  2. core-ci voted on patch set 1 V -1 11/08/22, 14:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33314

  3. Benjamin Kott uploaded patch set 2 11/09/22, 07:11

  4. Benjamin Kott uploaded patch set 3 11/09/22, 07:21

  5. core-ci voted on patch set 2 V -1 11/09/22, 07:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33368

  6. core-ci voted on patch set 3 V -1 11/09/22, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33369

  7. Benjamin Kott uploaded patch set 4 11/09/22, 10:49

  8. core-ci voted on patch set 4 V -1 11/09/22, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33394

  9. Benjamin Kott uploaded patch set 5 11/09/22, 11:45

  10. core-ci voted on patch set 5 V -1 11/09/22, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33397

  11. Benjamin Kott uploaded patch set 6 11/10/22, 10:24

  12. core-ci voted on patch set 6 V -1 11/10/22, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33451

  13. Benjamin Kott uploaded patch set 7 11/10/22, 13:57

  14. core-ci voted on patch set 7 V -1 11/10/22, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33495

  15. Benjamin Kott uploaded patch set 8 11/10/22, 14:37

  16. core-ci voted on patch set 8 V -1 11/10/22, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33499

  17. Benjamin Kott uploaded patch set 9 11/10/22, 15:40

  18. core-ci voted on patch set 9 V -1 11/10/22, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33510

  19. Benjamin Kott uploaded patch set 10 11/11/22, 10:28

  20. core-ci voted on patch set 10 V -1 11/11/22, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33561

  21. Benjamin Kott uploaded patch set 11 11/11/22, 12:08

  22. core-ci voted on patch set 11 V -1 11/11/22, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33576

  23. Benjamin Kott uploaded patch set 12 11/11/22, 15:32

  24. core-ci voted on patch set 12 V -1 11/11/22, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33596

  25. Benjamin Kott uploaded patch set 13 11/11/22, 16:01

  26. core-ci voted on patch set 13 V -1 11/11/22, 16:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33598

  27. Josef Glatz updated the commit message in patch set 14 11/14/22, 05:39

  28. core-ci voted on patch set 14 V -1 11/14/22, 05:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33684

  29. Benjamin Kott uploaded patch set 15 11/14/22, 09:02

  30. core-ci voted on patch set 15 V -1 11/14/22, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33690

  31. Benjamin Kott uploaded patch set 16 11/14/22, 11:09

  32. core-ci voted on patch set 16 V -1 11/14/22, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33697

  33. Benjamin Kott uploaded patch set 17 11/15/22, 07:16

  34. core-ci voted on patch set 17 V -1 11/15/22, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33733

  35. Josef Glatz updated the commit message in patch set 18 11/15/22, 10:34

  36. core-ci voted on patch set 18 V -1 11/15/22, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33744

  37. Benjamin Kott uploaded patch set 19 11/16/22, 08:20

  38. Benjamin Kott uploaded patch set 20 11/16/22, 08:21

  39. core-ci voted on patch set 19 V -1 11/16/22, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33809

  40. core-ci voted on patch set 20 V -1 11/16/22, 08:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33810

  41. Benjamin Kott uploaded patch set 21 11/16/22, 09:22

  42. core-ci voted on patch set 21 V -1 11/16/22, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33813

  43. Benjamin Kott uploaded patch set 22 11/16/22, 09:42

  44. core-ci voted on patch set 22 V -1 11/16/22, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33817

  45. Benjamin Kott uploaded patch set 23 11/16/22, 12:03

  46. core-ci voted on patch set 23 V -1 11/16/22, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33823

  47. Benjamin Kott uploaded patch set 24 11/17/22, 09:36

  48. core-ci voted on patch set 24 V -1 11/17/22, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33859

  49. Benjamin Kott uploaded patch set 25 11/17/22, 14:04

  50. core-ci voted on patch set 25 V -1 11/17/22, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33871

  51. Benjamin Kott uploaded patch set 26 11/17/22, 14:39

  52. core-ci voted on patch set 26 V -1 11/17/22, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33874

  53. Benjamin Kott uploaded patch set 27 11/17/22, 15:44

  54. core-ci voted on patch set 27 V -1 11/17/22, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33878

  55. Benjamin Kott rebased onto patch set 28 11/18/22, 08:30

  56. core-ci voted on patch set 28 V -1 11/18/22, 08:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33901

  57. Benjamin Kott uploaded patch set 29 11/18/22, 12:56

  58. core-ci voted on patch set 29 V -1 11/18/22, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33918

  59. Benjamin Kott uploaded patch set 30 11/18/22, 14:44

  60. core-ci voted on patch set 30 V -1 11/18/22, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33919

  61. Benjamin Kott uploaded patch set 31 11/18/22, 15:13

  62. Benjamin Kott uploaded patch set 32 11/18/22, 15:26

  63. core-ci voted on patch set 31 V -1 11/18/22, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33922

  64. core-ci voted on patch set 32 V -1 11/18/22, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33923

  65. Benjamin Kott uploaded patch set 33 V -1 11/21/22, 07:59

  66. core-ci voted on patch set 33 V -1 11/21/22, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34027

  67. Benjamin Kott uploaded patch set 34 V -1 11/21/22, 12:48

  68. core-ci voted on patch set 34 V -1 11/21/22, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34041

  69. Benjamin Kott uploaded patch set 35 V -1 11/21/22, 13:22

  70. core-ci voted on patch set 35 V -1 11/21/22, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34042

  71. Benjamin Kott uploaded patch set 36 V -1 11/21/22, 14:13

  72. core-ci voted on patch set 36 V -1 11/21/22, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34043

  73. Benjamin Kott uploaded patch set 37 V -1 11/21/22, 15:01

  74. Benjamin Kott uploaded patch set 38 11/21/22, 15:03

  75. core-ci voted on patch set 37 V -1 11/21/22, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34044

  76. core-ci voted on patch set 38 V -1 11/21/22, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34045

  77. Benjamin Kott uploaded patch set 39 V -1 11/22/22, 11:07

  78. core-ci voted on patch set 39 V +1 11/22/22, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34066

  79. Benjamin Kott uploaded patch set 40 V +1 11/22/22, 11:26

  80. Benjamin Kott uploaded patch set 41 11/22/22, 11:28

  81. Benjamin Kott updated the commit message in patch set 42 11/22/22, 11:29

  1. core-ci voted on patch set 40 V +1 11/22/22, 11:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34067

  2. core-ci voted on patch set 41 V +1 11/22/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34068

  3. core-ci voted on patch set 42 V +1 11/22/22, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34069

  4. Georg Ringer commented on patch set 42 CR +1 11/22/22, 11:53

    awesome! some little input: the chechbox is a bit hard to hit as it is rather small and especially because the image is linked it is very hard to check multiple images without triggering a detail link - ideas: clicking the image should trigger the checkbox using a label tag and a separate detail link? - some margin around the checkbox? - always show the checkbox + move it somewhere else so that clicking some pixel around won't trigger an action - kind of safe zone around the checkbox
  5. Georg Ringer voted on patch set 42 V -1 11/22/22, 11:54

  6. Benjamin Kott commented on patch set 42 11/22/22, 12:03

    Reply

    Hey, I agree that there are more optimizations possible. For now, the focus is to get a workable state in that we can improve and battle test until LTS. There are multiple things missing in this one. - Improve selection on touch devices - Improve multi record selections - Improve selections in general - Improve keyboard selections by hitting space - Check if we can enable multiple selections by dragging the mouse. - Make this view available in the link browser - Improve display of folders, file counter preview of images inside etc - ... The list is not short, think it´s better to get a starter patch in that as mentioned works and has no major drawbacks. So we can focus on little details afterwards.
  7. Georg Ringer commented on patch set 42 V +1 11/22/22, 12:13

    thanks for the detailed answer. changed to a +1
  8. Andreas Kienast commented on patch set 42 11/22/22, 13:00

    FileList.php:214

    Could this be private?
  9. Benjamin Kott commented on patch set 42 11/22/22, 13:03

    FileList.php:214 Reply

    yes, should be
  10. Christian Kuhn commented on patch set 42 CR -1 11/22/22, 13:30

    will give this a php-side review soon.
  11. Benjamin Kott commented on patch set 42 11/22/22, 13:35

    Reply

    <3
  12. Benjamin Kott uploaded patch set 43 CR +1 V +1 11/23/22, 07:03

  13. Benjamin Kott commented on patch set 43 CR -1 11/23/22, 07:04

    rebase, waiting for code review of lolli
  14. Benjamin Kott commented on patch set 43 11/23/22, 07:04

    FileList.php:214 Reply

    Done
  15. core-ci voted on patch set 43 V +1 11/23/22, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34099

  16. Benni Mack uploaded patch set 44 CR -1 V +1 11/23/22, 08:56

  17. core-ci voted on patch set 44 V +1 11/23/22, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34103

  18. Benni Mack uploaded patch set 45 V +1 11/23/22, 09:05

  19. core-ci voted on patch set 45 V +1 11/23/22, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34104

  20. Benni Mack voted on patch set 45 V +1 CR +1 11/23/22, 09:15

  21. Benni Mack commented on patch set 45 11/23/22, 09:15

    Reply

    Done
  22. Andreas Kienast voted on patch set 45 V +1 CR +1 11/23/22, 09:17

  23. Frank Nägler voted on patch set 45 V +1 CR +1 11/23/22, 09:30

  24. Andreas Kienast voted on patch set 45 V +2 CR +2 11/23/22, 09:32

  25. Andreas Kienast merged patch set 46 11/23/22, 09:32