Review main Merged

76485[BUGFIX] Also consider select fields for slug generation

Oli Bartsch CR +2 V +2 Easy +13 −9 updated 11/08/22, 17:04

Commit message

Generation of a slug proposal based on defined
generator fields does now also work for basic select
fields, which were previously not considered by the
JS component, because they do not use the FormEngine
specific visible / hidden field combination.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/08/22, 14:29

  2. core-ci voted on patch set 1 V +1 11/08/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33318

  3. Susi Moog voted on patch set 1 V +1 CR +1 11/08/22, 15:00

  4. Benni Mack voted on patch set 1 V +1 CR +1 11/08/22, 16:08

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 11/08/22, 17:04

  6. Oli Bartsch merged patch set 2 11/08/22, 17:04