Review main Merged

76491[FEATURE] Move site settings into settings.yaml

Bastien Lutz CR +2 V +2 Hard +305 −0 updated 11/10/22, 13:00

Commit message

Site Settings were introduced with TYPO3 v10.

In contrast to the rest of the site configuration,
site settings are sane defaults for TypoScript constants,
and consist of simple key value logic.

In order to separate settings, make them
accessible and editable in the TYPO3 Backend,
and distinguish between the functionality between
required site configuration and optional settings,
the "settings" part of the settings are moved to
a separate "settings.yaml" file in the site configuration
folder, which will later-on be editable by the TYPO3 Backend
with the new Settings API introduced in a separate patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2954

Show 1529 earlier messages
  1. Bastien Lutz uploaded patch set 1 11/08/22, 18:04

  2. Oliver Klee updated the commit message in patch set 2 11/08/22, 18:09

  3. core-ci voted on patch set 2 V +1 11/08/22, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33337

  4. core-ci voted on patch set 1 V +1 11/08/22, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33336

  5. Bastien Lutz uploaded patch set 3 11/08/22, 19:46

  6. Bastien Lutz rebased onto patch set 4 11/08/22, 19:48

  7. Bastien Lutz uploaded patch set 5 11/08/22, 19:54

  8. core-ci voted on patch set 3 V +1 11/08/22, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33349

  9. core-ci voted on patch set 4 V +1 11/08/22, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33351

  10. Bastien Lutz uploaded patch set 6 11/08/22, 20:02

  11. core-ci voted on patch set 5 V -1 11/08/22, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33354

  12. core-ci voted on patch set 6 V -1 11/08/22, 20:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33355

  13. Bastien Lutz uploaded patch set 7 11/09/22, 08:03

  14. Bastien Lutz updated the commit message in patch set 8 11/09/22, 08:06

  15. core-ci voted on patch set 7 V -1 11/09/22, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33370

  16. core-ci voted on patch set 8 V -1 11/09/22, 08:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33371

  17. Bastien Lutz uploaded patch set 9 11/09/22, 08:55

  18. core-ci voted on patch set 9 V -1 11/09/22, 09:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33380

  19. Bastien Lutz uploaded patch set 10 11/09/22, 09:38

  20. core-ci voted on patch set 10 V -1 11/09/22, 09:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33388

  21. Bastien Lutz uploaded patch set 11 11/09/22, 10:09

  22. core-ci voted on patch set 11 V +1 11/09/22, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33389

  23. Bastien Lutz uploaded patch set 12 11/09/22, 16:08

  24. core-ci voted on patch set 12 V -1 11/09/22, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33409

  25. Bastien Lutz uploaded patch set 13 11/10/22, 08:10

  26. core-ci voted on patch set 13 V -1 11/10/22, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33434

  27. Bastien Lutz uploaded patch set 14 11/10/22, 08:26

  28. core-ci voted on patch set 14 V -1 11/10/22, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33437

  29. Bastien Lutz uploaded patch set 15 11/10/22, 08:37

  1. core-ci voted on patch set 15 V -1 11/10/22, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33439

  2. Bastien Lutz uploaded patch set 16 11/10/22, 09:02

  3. Bastien Lutz rebased onto patch set 17 11/10/22, 09:04

  4. core-ci voted on patch set 16 V -1 11/10/22, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33441

  5. Bastien Lutz uploaded patch set 18 11/10/22, 09:11

  6. core-ci voted on patch set 17 V -1 11/10/22, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33442

  7. Bastien Lutz updated the commit message in patch set 19 11/10/22, 09:17

  8. core-ci voted on patch set 18 V +1 11/10/22, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33443

  9. core-ci voted on patch set 19 V +1 11/10/22, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33445

  10. Benni Mack uploaded patch set 20 11/10/22, 09:55

  11. core-ci voted on patch set 20 V -1 11/10/22, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33449

  12. Susi Moog uploaded patch set 21 11/10/22, 11:42

  13. Benni Mack uploaded patch set 22 11/10/22, 11:45

  14. core-ci voted on patch set 21 V +1 11/10/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33467

  15. core-ci voted on patch set 22 V +1 11/10/22, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33468

  16. Susi Moog uploaded patch set 23 11/10/22, 12:02

  17. Susi Moog updated the commit message in patch set 24 11/10/22, 12:02

  18. Benni Mack uploaded patch set 25 11/10/22, 12:04

  19. Benni Mack voted on patch set 25 V +1 CR +1 11/10/22, 12:08

  20. core-ci voted on patch set 23 V +1 11/10/22, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33473

  21. Susi Moog voted on patch set 25 V +1 CR +1 11/10/22, 12:24

  22. core-ci voted on patch set 24 V +1 11/10/22, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33474

  23. core-ci voted on patch set 25 V +1 11/10/22, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33476

  24. Benni Mack voted on patch set 25 V +2 CR +2 11/10/22, 13:00

  25. Benni Mack merged patch set 26 11/10/22, 13:00