76517[FEATURE] Introduce cObject for Extbase plugins
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Jochen Roth +1
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Jochen Roth +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-100293-NewContentObjectEXTBASEPLUGINInTypoScript.rstnew+55 −0
- typo3/sysext/extbase/Classes/ContentObject/ExtbasePluginContentObject.phpnew+65 −0
- typo3/sysext/extbase/Classes/Core/Bootstrap.php2+10 −1
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php6+2 −4
- typo3/sysext/extbase/Configuration/Services.yaml+6 −0
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+5 −6
- typo3/sysext/frontend/Classes/ContentObject/UserContentObject.php+1 −1
Review log 2127
Show 2 earlier messages
-
core-ci voted on patch set 1 V -1 11/09/22, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33393
-
core-ci voted on patch set 2 V -1 11/09/22, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33396
-
Benni Mack uploaded patch set 3 11/10/22, 08:17
-
Georg Ringer commented on patch set 3 11/10/22, 08:25
-
Benni Mack commented on patch set 3 11/10/22, 08:27
ExtensionUtility.php:78Replywe might just introduce "signature"? -
core-ci voted on patch set 3 V -1 11/10/22, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33435
-
Bastien Lutz uploaded patch set 4 11/10/22, 21:52
-
core-ci voted on patch set 4 V -1 11/10/22, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33534
-
Benni Mack commented on patch set 4 CR -1 11/16/22, 12:32
does not work yet as is. -
Benni Mack commented on patch set 4 11/16/22, 17:26
This patch does not work (yet), as USER_INT (which is used in ExtbasePluginContentObject) requires a "userFunc" property. Maybe we should finish https://review.typo3.org/c/Packages/TYPO3.CMS/+/74533 first. -
Benni Mack uploaded patch set 5
CR -1V -103/16/23, 23:23 -
core-ci voted on patch set 5 V +1 03/16/23, 23:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39087
-
Alexander Schnitzler commented on patch set 5 03/17/23, 08:08
Bootstrap.php:143Marking this internal takes the possibility to dispatch an Extbase frontend request without creating an ExtbasePluginContentObject. This is fine whenever the TSFE dispatched the request but it makes it even harder for users who want to dispatch (an uncached) request in a middleware (often used for apis). I think this patch goes very well hand in hand with my idea of ServerRequestHandlers: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75554 The caching (USER_INT) could be removed from my proposed FrontendRequestHandler and remain in the new ContentObject but your new ContentObject could dispatch a prepared ServerRequest via my new FrontendRequestHandler and users could also use the FrontendRequestHandler in middlewares. We both aim to get rid of the Bootstrap class. wdyt? -
Benni Mack commented on patch set 5 03/20/23, 15:37
ExtensionUtility.php:78ReplyOr just pluginName = $extensionName . '.' . $pluginName and then check if a dot exists, if there is no dot, we do not require the "extensionName" config key. -
Alexander Schnitzler commented on patch set 5 03/24/23, 07:01
Bootstrap.php:143ReplyForget about my patch. Let's mark this internal now, extract the ContentObject related code from the Bootstrap to the ContentObject (USER/USER_INT) and later on create different entry points that allow dispatching the ServerRequest. -
Alexander Schnitzler commented on patch set 5 03/24/23, 07:05
ExtensionUtility.php:78ReplyPlease have in mind that we have different wordings `extensionKey` and `extensionName`. `extensionName` usually is the camelCaseVersion of `extensionkey`, in this case lower(camelCaseVersion), so I wouldn't drop `name` in the variable name and maybe not even in the typoscript key. -
Benni Mack commented on patch set 5 03/24/23, 07:50
ExtensionUtility.php:78Replylet's keep it as is. -
Benni Mack commented on patch set 5 03/24/23, 07:50
ExtensionUtility.php:78ReplyDone -
Benni Mack uploaded patch set 6
V +103/24/23, 15:56 -
Benni Mack wrote 03/24/23, 15:58
Topic set to extbase -
core-ci voted on patch set 6 V +1 03/24/23, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39572
-
Andreas Kienast voted on patch set 6 V +1 CR +1 03/27/23, 08:26
-
Jochen Roth voted on patch set 6 V +1 CR +1 03/27/23, 17:45
-
Georg Ringer voted on patch set 6 V +2 CR +2 03/27/23, 18:27
-
Georg Ringer merged patch set 7 03/27/23, 18:27
ExtensionUtility.php:78