Review main Merged

76521[TASK] Ensure auto-created redirect are stored on site root

Stefan Bürk CR +2 V +2 Hard +346 −33 updated 11/11/22, 13:28

Commit message

Long time back auto-created redirects were created on
page "0", which has been changed meanwhile to create them
using the pageId of the changed page as `pid`.

With this change, auto-created redirects now use the
siteConfigs rootPageId as `pid`. This acts as a preparation
for following features and site based redirects editing
capabilities.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 14

Review log 1929

Show 34 earlier messages
  1. Stefan Bürk uploaded patch set 1 11/09/22, 15:40

  2. Stefan Bürk uploaded patch set 2 11/09/22, 15:50

  3. core-ci voted on patch set 1 V -1 11/09/22, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33404

  4. Stefan Bürk uploaded patch set 3 11/09/22, 15:52

  1. core-ci voted on patch set 2 V -1 11/09/22, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33405

  2. Stefan Bürk uploaded patch set 4 11/09/22, 15:58

  3. core-ci voted on patch set 4 V -1 11/09/22, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33407

  4. Stefan Bürk uploaded patch set 5 11/09/22, 16:27

  5. core-ci voted on patch set 5 V +1 11/09/22, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33416

  6. Stefan Bürk uploaded patch set 6 11/10/22, 11:07

  7. core-ci voted on patch set 6 V +1 11/10/22, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33457

  8. Benni Mack commented on patch set 6 11/10/22, 11:38

    SlugService.php:91

    can we keep the properties "protected" instead of moving them to private?
  9. Stefan Bürk commented on patch set 7 11/10/22, 12:06

    Published edit on patch set 6.
  10. Stefan Bürk commented on patch set 7 11/10/22, 12:07

    SlugService.php:91 Reply

    Good point. Done.
  11. core-ci voted on patch set 7 V +1 11/10/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33481

  12. Georg Ringer commented on patch set 8 11/10/22, 12:51

    Published edit on patch set 7.
  13. core-ci voted on patch set 8 V +1 11/10/22, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33488

  14. Benni Mack voted on patch set 8 V +1 CR +1 11/10/22, 13:05

  15. Benni Mack commented on patch set 9 11/11/22, 10:34

    Published edit on patch set 8.
  16. Benni Mack voted on patch set 9 V +1 CR +1 11/11/22, 10:35

  17. core-ci voted on patch set 9 V +1 11/11/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33563

  18. Anja Leichsenring updated the commit message in patch set 10 11/11/22, 10:49

  19. Anja Leichsenring commented on patch set 11 11/11/22, 10:49

    Published edit on patch set 10.
  20. Anja Leichsenring voted on patch set 11 V +1 CR +1 11/11/22, 10:51

  21. Benni Mack voted on patch set 11 V +1 CR +1 11/11/22, 10:55

  22. core-ci voted on patch set 11 V +1 11/11/22, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33565

  23. core-ci voted on patch set 10 V +1 11/11/22, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33564

  24. Benni Mack voted on patch set 11 V +2 CR +2 11/11/22, 13:28

  25. Benni Mack merged patch set 12 11/11/22, 13:28