Review main Merged

76522[FEATURE] Add PSR-14 event to ignore tables in Live Search

Andreas Kienast CR +2 V +2 Normal +199 −8 updated 11/10/22, 13:06

Commit message

The TYPO3 backend search (aka "Live Search") has a
`\TYPO3\CMS\Backend\Search\LiveSearch\DatabaseRecordProvider` that
searches all records in database tables that have `searchFields`
configured.

In some individual cases it may not be desired to search in a certain
table, therefore a new event `BeforeSearchInDatabaseRecordProviderEvent`
is introduced to add tables to a deny list.

The event is directly used by TYPO3 to exclude the "pages" table.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1015

  1. Andreas Kienast uploaded patch set 1 11/09/22, 16:08

  2. core-ci voted on patch set 1 V +1 11/09/22, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33408

  3. Benni Mack uploaded patch set 2 11/10/22, 07:57

  4. core-ci voted on patch set 2 V -1 11/10/22, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33430

  5. Andreas Kienast uploaded patch set 3 11/10/22, 08:31

  6. core-ci voted on patch set 3 V +1 11/10/22, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33438

  7. Oli Bartsch commented on patch set 3 CR -1 11/10/22, 10:40

    reviewing ..
  8. Oli Bartsch uploaded patch set 4 11/10/22, 11:53

  9. Oli Bartsch voted on patch set 4 V +1 CR +1 11/10/22, 11:53

  10. Benni Mack commented on patch set 5 11/10/22, 12:11

    Published edit on patch set 4.
  11. Benni Mack voted on patch set 5 V +1 CR +1 11/10/22, 12:11

  12. core-ci voted on patch set 4 V +1 11/10/22, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33471

  13. core-ci voted on patch set 5 V +1 11/10/22, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33482

  14. Oli Bartsch voted on patch set 5 V +2 CR +2 11/10/22, 13:06

  15. Oli Bartsch merged patch set 6 11/10/22, 13:06