Review main Merged

76523[BUGFIX] Allow no values in selectCheckbox in DataHandler

Bastien Lutz CR +2 V +2 Normal +91 −14 updated 11/10/22, 08:49

Commit message

With Doctrine DBAL in TYPO3 v8, a default value for
various fields were added to avoid SQL errors (nullable),
setting them to their default value.

However, there is a culprit. When editing e.g.
be_users.file_permissions where you have selectCheckbox field
with all options, it was never possible to unselect all, as
the default value was then used.

Through some workarounds, DataHandler now checks
the modified records on the selectCheckbox type to not
fall back on the default value.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 812

  1. Bastien Lutz uploaded patch set 1 11/09/22, 16:11

  2. core-ci voted on patch set 1 V -1 11/09/22, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33411

  3. Benni Mack rebased onto patch set 2 11/10/22, 08:06

  4. Benni Mack updated the commit message in patch set 3 11/10/22, 08:09

  5. core-ci voted on patch set 3 V +1 11/10/22, 08:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33433

  6. Markus Klein updated the commit message in patch set 4 11/10/22, 08:22

  7. core-ci voted on patch set 2 V -1 11/10/22, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33432

  8. core-ci voted on patch set 4 V +1 11/10/22, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33436

  9. Benni Mack voted on patch set 4 V +1 11/10/22, 08:32

  10. Benni Mack commented on patch set 4 CR +1 11/10/22, 08:33

    not a huge fan of the check of the renderType in DataHandler, but it solves a huge longstanding issue since TYPO3 v6.2
  11. Stefan Bürk commented on patch set 4 V +2 CR +2 11/10/22, 08:49

    Reply

    same here. but better fix it now.
  12. Stefan Bürk merged patch set 5 11/10/22, 08:49