76524[FEATURE] Introduce global static routes
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 8
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Configuration/FactoryConfiguration.php+3 −0
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-89518-IntroduceGlobalStaticRoutes.rstnew+50 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php1+16 −0
- typo3/sysext/frontend/Classes/Middleware/StaticRouteResolver.php4+87 −37
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+7 −3
- typo3/sysext/frontend/Tests/Unit/Middleware/StaticRouteResolverTest.php+44 −16
Review log 2131
Show 36 earlier messages
-
Susi Moog uploaded patch set 1 11/09/22, 16:19
-
Susi Moog updated the commit message in patch set 2 11/09/22, 16:19
-
core-ci voted on patch set 1 V -1 11/09/22, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33412
-
core-ci voted on patch set 2 V -1 11/09/22, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33413
-
Susi Moog uploaded patch set 3 11/10/22, 07:55
-
core-ci voted on patch set 3 V -1 11/10/22, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33429
-
Susi Moog uploaded patch set 4 11/10/22, 09:30
-
core-ci voted on patch set 4 V -1 11/10/22, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33446
-
Susi Moog uploaded patch set 5 11/10/22, 09:47
-
core-ci voted on patch set 5 V -1 11/10/22, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33447
-
Susi Moog uploaded patch set 6 11/10/22, 15:48
-
core-ci voted on patch set 6 V -1 11/10/22, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33513
-
Susi Moog uploaded patch set 7 11/10/22, 17:37
-
core-ci voted on patch set 7 V +1 11/10/22, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33523
-
Susi Moog updated the commit message in patch set 8 11/10/22, 17:49
-
Susi Moog marked it ready for review 11/10/22, 17:49
-
core-ci voted on patch set 8 V +1 11/10/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33524
-
Benni Mack commented on patch set 8 CR -1 11/10/22, 19:06
-
Susi Moog commented on patch set 9 11/10/22, 19:07
Published edit on patch set 8. -
Benni Mack commented on patch set 9 11/10/22, 19:08
SiteConfiguration.php:238how is this change related? -
core-ci voted on patch set 9 V +1 11/10/22, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33527
-
Susi Moog commented on patch set 10 11/11/22, 07:53
Published edit on patch set 9. -
core-ci voted on patch set 10 V +1 11/11/22, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33547
-
Susi Moog commented on patch set 10 11/11/22, 08:02
SiteConfiguration.php:238ReplyDoneStaticRouteResolver.php:28ReplyDone -
Jörg Bösche voted on patch set 10 CR +1 11/11/22, 14:25
-
Stefan Bürk commented on patch set 10 11/13/22, 02:26
SiteConfigurationTest.php:48UnresolvedInstead of setting this in the setUp method, this should be configured directly as property ``` protected bool $backupEnvironment = true; ```StaticRouteResolver.php:104Not a fan of yaml parsing on each request. Would like it more to have some kind of "service" for the global statiRoutes configuration loading, which uses a php file based cache (thus taking benefit from opcache if available). -
Susi Moog commented on patch set 10 CR -1 11/14/22, 08:03
-1 until Stefans comment is implemented.StaticRouteResolver.php:104Reply Unresolvedgood idea - will see when I can do this. -
Benni Mack commented on patch set 10 11/16/22, 10:31
There might be a better approach than the static routes... -
Susi Moog commented on patch set 10 11/16/22, 12:54
Reply Unresolved
Quick notes from phone call: - leave static routes alone - introduce global routes as after-site-and-auth-pre-redirect middleware with own router and dynamic and static capabilities -
Susi Moog commented on patch set 10 11/17/22, 10:16
other approach: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76662 -
Susi Moog abandoned the change 01/06/23, 13:03
StaticRouteResolver.php:28