Review main Abandoned

76524[FEATURE] Introduce global static routes

Susi Moog CR 0 V 0 Hard +211 −56 updated 01/06/23, 13:03

Commit message

To allow configuring routes that are independent
of a site, a new feature (and corresponding toggle)
has been implemented: Global static routes.

These routes can be configured in the file
`system/staticRoutes.yaml` and will be resolved
before any other route resolving happens - the
middleware stack is reordered to allow static
route resolving before the base redirect kicks in.

For new systems the feature toggle is enabled by
default, upgraded systems need to manually enable
this feature.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 8

Review log 2131

Show 36 earlier messages
  1. Susi Moog uploaded patch set 1 11/09/22, 16:19

  2. Susi Moog updated the commit message in patch set 2 11/09/22, 16:19

  3. core-ci voted on patch set 1 V -1 11/09/22, 16:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33412

  4. core-ci voted on patch set 2 V -1 11/09/22, 16:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33413

  5. Susi Moog uploaded patch set 3 11/10/22, 07:55

  6. core-ci voted on patch set 3 V -1 11/10/22, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33429

  1. Susi Moog uploaded patch set 4 11/10/22, 09:30

  2. core-ci voted on patch set 4 V -1 11/10/22, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33446

  3. Susi Moog uploaded patch set 5 11/10/22, 09:47

  4. core-ci voted on patch set 5 V -1 11/10/22, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33447

  5. Susi Moog uploaded patch set 6 11/10/22, 15:48

  6. core-ci voted on patch set 6 V -1 11/10/22, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33513

  7. Susi Moog uploaded patch set 7 11/10/22, 17:37

  8. core-ci voted on patch set 7 V +1 11/10/22, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33523

  9. Susi Moog updated the commit message in patch set 8 11/10/22, 17:49

  10. Susi Moog marked it ready for review 11/10/22, 17:49

  11. core-ci voted on patch set 8 V +1 11/10/22, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33524

  12. Benni Mack commented on patch set 8 CR -1 11/10/22, 19:06

    StaticRouteResolver.php:28

    why is this added again?
  13. Susi Moog commented on patch set 9 11/10/22, 19:07

    Published edit on patch set 8.
  14. Benni Mack commented on patch set 9 11/10/22, 19:08

    SiteConfiguration.php:238

    how is this change related?
  15. core-ci voted on patch set 9 V +1 11/10/22, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33527

  16. Susi Moog commented on patch set 10 11/11/22, 07:53

    Published edit on patch set 9.
  17. core-ci voted on patch set 10 V +1 11/11/22, 08:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33547

  18. Susi Moog commented on patch set 10 11/11/22, 08:02

    SiteConfiguration.php:238 Reply

    Done

    StaticRouteResolver.php:28 Reply

    Done
  19. Jörg Bösche voted on patch set 10 CR +1 11/11/22, 14:25

  20. Stefan Bürk commented on patch set 10 11/13/22, 02:26

    SiteConfigurationTest.php:48 Unresolved

    Instead of setting this in the setUp method, this should be configured directly as property ``` protected bool $backupEnvironment = true; ```

    StaticRouteResolver.php:104

    Not a fan of yaml parsing on each request. Would like it more to have some kind of "service" for the global statiRoutes configuration loading, which uses a php file based cache (thus taking benefit from opcache if available).
  21. Susi Moog commented on patch set 10 CR -1 11/14/22, 08:03

    -1 until Stefans comment is implemented.

    StaticRouteResolver.php:104 Reply Unresolved

    good idea - will see when I can do this.
  22. Benni Mack commented on patch set 10 11/16/22, 10:31

    There might be a better approach than the static routes...
  23. Susi Moog commented on patch set 10 11/16/22, 12:54

    Reply Unresolved

    Quick notes from phone call: - leave static routes alone - introduce global routes as after-site-and-auth-pre-redirect middleware with own router and dynamic and static capabilities
  24. Susi Moog commented on patch set 10 11/17/22, 10:16

  25. Susi Moog abandoned the change 01/06/23, 13:03