Review main Merged

76532[TASK] Deprecate TypoScript setup "constants" TLO

Christian Kuhn CR +2 V +2 Normal +142 −48 updated 02/14/23, 10:52

Commit message

This is not about TypoScript constants/settings
that are accessed using {$myConstant} in TypoScript
setup.

This is about the TypoScript setup "constants"
top-level-object: It is used in TypoScript
"parseFunc" and allows referencing string literals
by name in "parseFunc" strings, which are substituted
by using ###theName###, when property "constants = 1" is
set in "parseFunc".

This feature dates back to Kasper's "Initial revision"
and is obsolete ever since: The feature exists next
to well-known TypoScript constants, existing
usages can be easily substituted. The confusion with
TypoScript "constants" alone justifies a deprecation
of this detail.

The patch deprecates both the TypoScript setup
"constants" top-level-object, plus the "constants"
property in "parseFunc".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2129

Show 24 earlier messages
  1. Christian Kuhn uploaded patch set 1 11/10/22, 10:07

  2. core-ci voted on patch set 1 V +1 11/10/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33450

  3. Christian Kuhn uploaded patch set 2 11/10/22, 10:58

  4. core-ci voted on patch set 2 V -1 11/10/22, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33456

  1. Christian Kuhn uploaded patch set 3 11/10/22, 11:16

  2. Christian Kuhn uploaded patch set 4 11/10/22, 11:21

  3. core-ci voted on patch set 4 V -1 11/10/22, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33460

  4. Christian Kuhn uploaded patch set 5 11/10/22, 11:38

  5. core-ci voted on patch set 5 V +1 11/10/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33465

  6. Benni Mack voted on patch set 5 V +1 CR +1 11/10/22, 12:16

  7. Benni Mack wrote 11/10/22, 12:17

    Removed reviewer core-ci with the following votes: * Verified+1 by core-ci
  8. Andreas Kienast updated the commit message in patch set 6 11/10/22, 12:20

  9. Benni Mack voted on patch set 6 V +1 CR +1 11/10/22, 12:34

  10. Christian Kuhn commented on patch set 6 CR -1 11/10/22, 12:45

    This has slightly more impact, will update documentation.rst file.
  11. core-ci voted on patch set 6 V +1 11/10/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33486

  12. Christian Kuhn uploaded patch set 7 11/10/22, 14:50

  13. core-ci voted on patch set 7 V +1 11/10/22, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33500

  14. Christian Kuhn uploaded patch set 8 11/10/22, 15:23

  15. Christian Kuhn uploaded patch set 9 11/10/22, 15:24

  16. core-ci voted on patch set 9 V +1 11/10/22, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33508

  17. core-ci voted on patch set 8 V +1 11/10/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33507

  18. Benni Mack voted on patch set 9 V +1 CR +1 11/10/22, 15:40

  19. Susi Moog voted on patch set 9 V +1 CR +1 11/10/22, 19:16

  20. Benni Mack voted on patch set 9 V +2 CR +2 11/10/22, 20:41

  21. Benni Mack merged patch set 10 11/10/22, 20:41

  22. Lina Wolf commented on patch set 10 11/27/22, 16:45

    What about the parseFunc "short" syntax? Has it also been removed? (https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Parsefunc.html#short)
  23. Stefan Bürk commented on patch set 10 11/27/22, 18:00

    Reply

    Nope, neighter deprecated nor removed. Works quite different tha the global constants marker replacement.
  24. Lina Wolf commented on patch set 10 11/27/22, 18:12

    Reply

    I would suggest to also deprecate userFunc.short as right now ppl could just switch from lib.parseFunc_RTE.constants = 1 to lib.parseFunc_RTE.short { // whatever was in tol constants before } which is clearly not what we intend to do here
  25. Christian Kuhn commented on patch set 10 02/14/23, 10:52

    Reply

    Ack