76532[TASK] Deprecate TypoScript setup "constants" TLO
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/12.1/Deprecation-99040-DeprecatedTypoScriptSetupConstantsTop-level-object.rstnew+92 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+3 −3
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlViewHelperTest.php+8 −9
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/Helper/ParseFunc.typoscript+1 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+26 −24
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+12 −12
Review log 2129
Show 24 earlier messages
-
Christian Kuhn uploaded patch set 1 11/10/22, 10:07
-
core-ci voted on patch set 1 V +1 11/10/22, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33450
-
Christian Kuhn uploaded patch set 2 11/10/22, 10:58
-
core-ci voted on patch set 2 V -1 11/10/22, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33456
-
Christian Kuhn uploaded patch set 3 11/10/22, 11:16
-
Christian Kuhn uploaded patch set 4 11/10/22, 11:21
-
core-ci voted on patch set 4 V -1 11/10/22, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33460
-
Christian Kuhn uploaded patch set 5 11/10/22, 11:38
-
core-ci voted on patch set 5 V +1 11/10/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33465
-
Benni Mack voted on patch set 5 V +1 CR +1 11/10/22, 12:16
-
Benni Mack wrote 11/10/22, 12:17
Removed reviewer core-ci with the following votes: * Verified+1 by core-ci -
Andreas Kienast updated the commit message in patch set 6 11/10/22, 12:20
-
Benni Mack voted on patch set 6 V +1 CR +1 11/10/22, 12:34
-
Christian Kuhn commented on patch set 6 CR -1 11/10/22, 12:45
This has slightly more impact, will update documentation.rst file. -
core-ci voted on patch set 6 V +1 11/10/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33486
-
Christian Kuhn uploaded patch set 7 11/10/22, 14:50
-
core-ci voted on patch set 7 V +1 11/10/22, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33500
-
Christian Kuhn uploaded patch set 8 11/10/22, 15:23
-
Christian Kuhn uploaded patch set 9 11/10/22, 15:24
-
core-ci voted on patch set 9 V +1 11/10/22, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33508
-
core-ci voted on patch set 8 V +1 11/10/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33507
-
Benni Mack voted on patch set 9 V +1 CR +1 11/10/22, 15:40
-
Susi Moog voted on patch set 9 V +1 CR +1 11/10/22, 19:16
-
Benni Mack voted on patch set 9 V +2 CR +2 11/10/22, 20:41
-
Benni Mack merged patch set 10 11/10/22, 20:41
-
Lina Wolf commented on patch set 10 11/27/22, 16:45
What about the parseFunc "short" syntax? Has it also been removed? (https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Parsefunc.html#short) -
Stefan Bürk commented on patch set 10 11/27/22, 18:00
Reply
Nope, neighter deprecated nor removed. Works quite different tha the global constants marker replacement. -
Lina Wolf commented on patch set 10 11/27/22, 18:12
Reply
I would suggest to also deprecate userFunc.short as right now ppl could just switch from lib.parseFunc_RTE.constants = 1 to lib.parseFunc_RTE.short { // whatever was in tol constants before } which is clearly not what we intend to do here -
Christian Kuhn commented on patch set 10 02/14/23, 10:52
Reply
Ack