Review main Merged

76533[TASK] Set "keepFilename" to true by default

Andreas Nedbal CR +2 V +2 Easy +1 −1 updated 11/10/22, 13:10

Commit message

One of the main use cases of replacing files is updating the content of a
referenced file with new revisions or changed content. The local filename
of the replacing file in most cases is not as relevant so by default
opting to keeping the filename makes sense for the end user.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 914

  1. Andreas Nedbal uploaded patch set 1 11/10/22, 10:25

  2. core-ci voted on patch set 1 V +1 11/10/22, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33452

  3. Andreas Nedbal updated the commit message in patch set 2 11/10/22, 12:01

  4. Oliver Klee updated the commit message in patch set 3 11/10/22, 12:05

  5. Oliver Klee updated the commit message in patch set 4 11/10/22, 12:05

  6. Benni Mack voted on patch set 4 CR +1 11/10/22, 12:12

  7. Andreas Nedbal updated the commit message in patch set 5 11/10/22, 12:12

  8. core-ci voted on patch set 2 V +1 11/10/22, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33472

  9. Benni Mack voted on patch set 5 V +1 CR +1 11/10/22, 12:20

  10. core-ci voted on patch set 5 V +1 11/10/22, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33483

  11. core-ci voted on patch set 3 V +1 11/10/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33479

  12. core-ci voted on patch set 4 V +1 11/10/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33480

  13. Oli Bartsch voted on patch set 5 V +2 CR +2 11/10/22, 13:10

  14. Oli Bartsch merged patch set 6 11/10/22, 13:10