76539[FEATURE] Add two PSR-14 events around auto create redirects
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Sybille Peters +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 4
- Feature #99834PSR-14 events around auto create redirects are use full for several use-cases
- Feature #99802Introducing a event to redirects ManagementController to modify view data helps to enrich view for custom view overrides
- Task #99044Ensure auto-created redirect are stored on connected site root
- Feature #91776Use the pid field to associate a redirect with the page it was created for
Files 10
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-99834-NewPSR-14AfterAutoCreateRedirectHasBeenPersistedEvent.rstnew+74 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-99834-NewPSR-14ModifyAutoCreateRedirectRecordBeforePersistingEvent.rstnew+85 −0
- typo3/sysext/redirects/Classes/Event/AfterAutoCreateRedirectHasBeenPersistedEvent.phpnew+54 −0
- typo3/sysext/redirects/Classes/Event/ModifyAutoCreateRedirectRecordBeforePersistingEvent.phpnew+59 −0
- typo3/sysext/redirects/Classes/Service/SlugService.php+19 −2
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_AfterAutoCreateRedirectHasBeenPersistedEvent.csvnew+4 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/SlugServiceTest_ModifyAutoCreateRedirectRecordBeforePersistingEvent.csvnew+4 −0
- typo3/sysext/redirects/Tests/Functional/Service/SlugServiceTest.php+119 −7
- typo3/sysext/redirects/Tests/Unit/Event/AfterAutoCreateRedirectHasBeenPersistedEventTest.phpnew+61 −0
- typo3/sysext/redirects/Tests/Unit/Event/ModifyAutoCreateRedirectRecordBeforePersistingEventTest.phpnew+97 −0
Review log 2638
Show 813 earlier messages
-
Stefan Bürk uploaded patch set 1 11/10/22, 12:13
-
core-ci voted on patch set 1 V -1 11/10/22, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33484
-
Stefan Bürk uploaded patch set 2 11/10/22, 14:36
-
Stefan Bürk uploaded patch set 3 02/03/23, 16:31
-
core-ci voted on patch set 3 V +1 02/03/23, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36999
-
Stefan Bürk updated the commit message in patch set 4
V +102/03/23, 16:43 -
core-ci voted on patch set 4 V +1 02/03/23, 16:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37001
-
Stefan Bürk uploaded patch set 5
V +102/05/23, 15:44 -
core-ci voted on patch set 5 V +1 02/05/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37118
-
Stefan Bürk uploaded patch set 6
V +102/05/23, 16:37 -
Stefan Bürk commented on patch set 6 02/05/23, 16:44
https://review.typo3.org/c/Packages/TYPO3.CMS/+/77672 must be merged first, as referenced in the changelog. -
core-ci voted on patch set 6 V +1 02/05/23, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37121
-
Stefan Bürk commented on patch set 7
V +102/05/23, 19:56Published edit on patch set 6.
-
core-ci voted on patch set 7 V +1 02/05/23, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37130
-
Benni Mack commented on patch set 8
V +102/08/23, 07:52Published edit on patch set 7. -
core-ci voted on patch set 8 V +1 02/08/23, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37332
-
Stefan Bürk voted on patch set 8 CR -1 02/09/23, 20:24
-
Stefan Bürk uploaded patch set 9
CR -1V +102/23/23, 10:52 -
Stefan Bürk updated the commit message in patch set 10 02/23/23, 10:53
-
Stefan Bürk commented on patch set 10 02/23/23, 10:53
Reply
Removed the cross reference for now, to avoid cross blocking. Should be fine without it anyway. -
core-ci voted on patch set 9 V +1 02/23/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38007
-
core-ci voted on patch set 10 V +1 02/23/23, 11:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38008
-
Sybille Peters uploaded patch set 11
V +102/25/23, 14:55 -
Sybille Peters commented on patch set 10 CR +1 02/25/23, 14:55
Feature-99834-NewPSR-14EventAfterAutoCreateRedirectHasBeenPersisted.rst:16> redirect redirectsFeature-99834-NewPSR-14EventAfterAutoCreateRedirectHasBeenPersisted.rst:27of the event listenerFeature-99834-NewPSR-14EventAfterAutoCreateRedirectHasBeenPersisted.rst:66> Manual ManuallyFeature-99834-NewPSR-14EventModifyAutoCreateRedirectRecordBeforePersisting.rst:17> circumstance circumstancesFeature-99834-NewPSR-14EventModifyAutoCreateRedirectRecordBeforePersisting.rst:23> manual manuallyFeature-99834-NewPSR-14EventModifyAutoCreateRedirectRecordBeforePersisting.rst:31could add :caption: Configuration/Services.yamlFeature-99834-NewPSR-14EventModifyAutoCreateRedirectRecordBeforePersisting.rst:78> Manual Manually -
core-ci voted on patch set 11 V +1 02/25/23, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38099
-
Sybille Peters voted on patch set 11 CR +1 02/25/23, 15:07
-
Sybille Peters commented on patch set 11 CR 0 02/25/23, 15:25
AfterAutoCreateRedirectHasBeenPersisted.php:31Why are events not named with Event suffix (this is the case with most of the other new events). > When creating a new event PHP class, it is recommended to add a Event suffix to the PHP class https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Events/EventDispatcher/Index.html -
Sybille Peters commented on patch set 11 02/25/23, 17:03
Feature-99834-NewPSR-14EventModifyAutoCreateRedirectRecordBeforePersisting.rst:23ReplyDone -
Stefan Bürk uploaded patch set 12
V +102/26/23, 14:59 -
Stefan Bürk commented on patch set 12 02/26/23, 15:02
AfterAutoCreateRedirectHasBeenPersisted.php:31ReplyGood point. In fact, not all core events follows this recommendation. Beside this, in the world of "code style and guidelines" there are a lot of opionions, there are prominent voices that if "Event" is in the namespace it's not neccessary to redo it in the class name for example. (Just as a general note). I can live with such a suggestion, and if it is documented public that way, you are right. Changed to follow this recommendation. Thanks for pointing this out. -
Sybille Peters voted on patch set 12 CR +1 02/26/23, 15:06
-
core-ci voted on patch set 12 V +1 02/26/23, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38117
-
Stefan Bürk uploaded patch set 13
CR +1V +102/26/23, 15:07 -
Sybille Peters voted on patch set 13 CR +1 02/26/23, 15:09
-
core-ci voted on patch set 13 V +1 02/26/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38118
-
Georg Ringer voted on patch set 13 V +1 CR +1 03/03/23, 11:52
-
Benni Mack voted on patch set 13 V +2 CR +2 03/07/23, 12:34
-
Benni Mack merged patch set 14 03/07/23, 12:34