Review main Merged

76541[TASK] Replace prophecy in EXT:core/*/UnitDeprecated/*/FileExtensionFilterTest

Torben Hansen CR +2 V +2 Easy +6 −9 updated 11/11/22, 10:15

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Torben Hansen uploaded patch set 1 11/10/22, 13:03

  2. core-ci voted on patch set 1 V +1 11/10/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33490

  3. Torben Hansen updated the commit message in patch set 2 11/10/22, 13:44

  4. Tomas Norre Mikkelsen voted on patch set 2 CR +1 11/10/22, 13:46

  5. core-ci voted on patch set 2 V +1 11/10/22, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33494

  6. Susi Moog voted on patch set 2 V +1 CR +1 11/10/22, 19:19

  7. Oliver Klee commented on patch set 2 CR -1 11/10/22, 19:45

    FileExtensionFilterTest.php:71

    In the variable names: *Prophecy -> *Mock
  8. Susi Moog commented on patch set 3 11/11/22, 08:03

    Published edit on patch set 2.
  9. Susi Moog commented on patch set 3 11/11/22, 08:03

    FileExtensionFilterTest.php:71 Reply

    Done
  10. Oliver Klee voted on patch set 3 V +1 CR +1 11/11/22, 08:09

  11. core-ci voted on patch set 3 V +1 11/11/22, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33548

  12. Benni Mack voted on patch set 3 V +2 CR +2 11/11/22, 10:15

  13. Benni Mack merged patch set 4 11/11/22, 10:15