76542[TASK] Deprecate _CSS_PAGE_STYLE and config.removePageCss
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Froemken +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Froemken +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/12.1/Deprecation-99050-TypoScript_CSS_PAGE_STYLEAndConfigremovePageCss.rstnew+75 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+11 −1
- typo3/sysext/seo/Configuration/TypoScript/XmlSitemap/setup.typoscript+1 −0
- typo3/sysext/t3editor/Resources/Private/tsref.xml+0 −4
Review log 1317
-
Christian Kuhn uploaded patch set 1 11/10/22, 13:22
-
Christian Kuhn voted on patch set 1 CR -1 11/10/22, 13:22
-
core-ci voted on patch set 1 V +1 11/10/22, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33493
-
Christian Kuhn uploaded patch set 2 11/10/22, 14:21
-
core-ci voted on patch set 2 V +1 11/10/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33496
-
Stefan Froemken voted on patch set 2 V +1 CR +1 11/10/22, 14:33
-
Christian Kuhn uploaded patch set 3 11/10/22, 14:33
-
core-ci voted on patch set 3 V +1 11/10/22, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33497
-
Stefan Froemken commented on patch set 3 V +1 CR +1 11/10/22, 15:14
Deprecation entry will be logged, yes, but because of PHP 8 using _CSS_PAGE_STYLE the implode function will throw an Argument exception. That's not a problem with THIS patch. It's a problem since over 3 years. IMO _CSS_PAGE_STYLE is broken for a very long time as implode will return NULL, if 2nd Argument is string. So, removing that feature is also an option for me. -
Christian Kuhn uploaded patch set 4 11/10/22, 15:16
-
Christian Kuhn commented on patch set 4 11/10/22, 15:18
Reply
yeah. just figured this as well. i fixed the warning in v12 now but skipped a v11 backport on this ... in case anyone runs into this, we can still have a dedicated v11 fix for this. -
core-ci voted on patch set 4 V +1 11/10/22, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33506
-
Benni Mack voted on patch set 4 V +1 CR +1 11/10/22, 15:38
-
Stefan Froemken commented on patch set 4 11/10/22, 15:38
If just config.removePageCss is 1 (without any _CSS_PAGE_STYLE) no deprecation log will be written. But that's OK for me. -
Stefan Froemken voted on patch set 4 V +1 CR +1 11/10/22, 15:38
-
Christian Kuhn voted on patch set 4 V +2 CR +2 11/10/22, 15:40
-
Christian Kuhn merged patch set 5 11/10/22, 15:40