76545[FEATURE] Add route aspect fallback value handling
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Stefan Froemken +1
-
Verified V +2 Done
- Stefan Bürk +2
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Routing/Aspect/MappableProcessor.php+4 −1
- typo3/sysext/core/Classes/Routing/Aspect/PersistedAliasMapper.php+2 −1
- typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php+2 −1
- typo3/sysext/core/Classes/Routing/Aspect/StaticValueMapper.php+2 −1
- typo3/sysext/core/Classes/Routing/Aspect/UnresolvedValueInterface.phpnew+27 −0
- typo3/sysext/core/Classes/Routing/Aspect/UnresolvedValueTrait.phpnew+47 −0
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-99053-RouteAspectFallbackValueHandling.rstnew+74 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/PersistedAliasMapperTest.php+61 −0
Review log 3947
Show 1822 earlier messages
-
Oliver Hader uploaded patch set 1 11/10/22, 15:43
-
core-ci voted on patch set 1 V +1 11/10/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33511
-
Oliver Hader uploaded patch set 2 11/11/22, 11:04
-
Oliver Hader commented on patch set 2 11/11/22, 11:05
This change is ready for review. -
core-ci voted on patch set 2 V -1 11/11/22, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33570
-
Oliver Hader uploaded patch set 3 11/11/22, 12:45
-
core-ci voted on patch set 3 V +1 11/11/22, 12:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33580
-
Jörg Bösche voted on patch set 3 CR +1 11/11/22, 14:20
-
Christian Kuhn voted on patch set 3 CR -1 11/11/22, 15:04
-
Georg Ringer commented on patch set 3 11/11/22, 15:59
Will test next week, awesome! However see no use case to provide a different value than null. Imo the dev/ext must care about fallback and behavior -
Oliver Hader commented on patch set 3 11/11/22, 17:54
Reply
> Will test next week, awesome! However see no use case to provide a different value than null. Imo the dev/ext must care about fallback and behavior It's like showing a 404 message (using a particular page), but using a particular record/entity in this scenario. -
Oliver Hader commented on patch set 3 11/11/22, 17:55
@lolli: What does the -1 mean? I could not find any comments/remarks.. -
Benni Mack commented on patch set 3 CR +1 11/11/22, 22:29
I called up Christian because of the -1. He mentioned the concept of the traits in this case, which was my idea in the sprint. I explained that he was concerned about using / introducing even more traits, but I think in the case of the Aspects (and how we added features more and more with the traits while not breaking BC) it's totally fine! -
Christian Kuhn commented on patch set 3 CR 0 11/12/22, 08:02
ah sorry. my text comment got lost somehow and leaving only the -1. i was concerned about the traits because i think they should be used for cross-cutting concerns only, and this case isn't one. looking at the aspects though, this is in-line with other traits though. i don't like it much, but it is how it is. as such, let's follow the concept for this patch, i'm removing the -1 again. -
Oliver Hader commented on patch set 3 CR -1 11/12/22, 10:18
For route enhancers those traits are used like "build your own toolbox with the tools (traits) we provide". Alternatives would have been inheritance (`AbstractEnhancer`) or duplicating the code to each of the shipped core enhancers. IMO, by using traits developers of custom enhancers can pick the feature set of their implementations best.Feature-99053-AddRouteAspectFallbackValueHandling.rst:49Add an example for custom enhancer implementations, using new interface & trait -
Oliver Hader uploaded patch set 4 11/12/22, 10:26
-
core-ci voted on patch set 4 V +1 11/12/22, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33624
-
Christian Kuhn commented on patch set 4 11/12/22, 12:23
Reply
yeah. fine with me. the patch follows what has been created before. -
Georg Ringer voted on patch set 4 V +1 CR +1 11/14/22, 13:09
-
Georg Ringer commented on patch set 4 V -1 11/16/22, 10:19
will do some additional testing tonight -
Georg Ringer voted on patch set 4 V +1 11/17/22, 05:59
-
Georg Ringer commented on patch set 4 11/17/22, 09:49
can be tested with tt_address, example tsconfig has been added to issue
-
Georg Ringer uploaded patch set 5
CR +1V +111/23/22, 09:16 -
core-ci voted on patch set 5 V +1 11/23/22, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34105
-
Georg Ringer voted on patch set 5 V +1 CR +1 11/23/22, 10:57
-
Stefan Froemken commented on patch set 5 11/23/22, 14:14
In rst file you have written "can be used", but in Trait you throw an Exception, if falBack is not defined. So fallBack is a must have, right? Should be updated in rst file. -
Stefan Froemken commented on patch set 5 11/23/22, 14:17
Reply
Narf...forget it...just see, you checked it in the MappableProcessor first. -
Stefan Froemken voted on patch set 5 V +1 CR +1 11/23/22, 14:33
-
Stefan Froemken commented on patch set 5 11/23/22, 14:42
It works, but what is the benefit of that patch? If URL with old/deleted identifier was called it results into an empty detail view now. So no 404 is thrown. So Google Search Console can not catch that and can not inform you about 404. But OK, I can change the fallBackValue to another record. I don't get it: The URL contains a kind of shoes, but in detail view I see a brand new blue car now. -
Oliver Hader commented on patch set 5 11/23/22, 16:37
Reply
> It works, but what is the benefit of that patch? If URL with old/deleted identifier was called it results into an empty detail view now. So no 404 is thrown. So Google Search Console can not catch that and can not inform you about 404. But OK, I can change the fallBackValue to another record. I don't get it: The URL contains a kind of shoes, but in detail view I see a brand new blue car now. What's your suggestion then? -
Stefan Froemken commented on patch set 5 11/24/22, 07:11
Reply
"My suggestion"? This patch and neither the forge ticket does not explain the problem it solves. I have written with Georg, yesterday. He brought some good points into the discussion: As a developer you want to react in your extension on missing records instead of TYPO3 responses with a 404. If an editor works with hide/start/endtime, it's better to react with a good message in frontend instead of 404. This patch lets the dev handle the situation. I miss a note about that in rst file. -
Oliver Hader commented on patch set 5 11/24/22, 08:42
Reply
Ok, so can you please provide a suggestion (= the actual text/description) to be added to the RST file? Thx! -
Stefan Froemken uploaded patch set 6
CR +1V +111/24/22, 10:11 -
Stefan Froemken commented on patch set 6 V +1 CR +1 11/24/22, 10:11
Reply
Done -
core-ci voted on patch set 6 V +1 11/24/22, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34163
-
Benni Mack commented on patch set 6 V +1 CR +1 11/24/22, 10:19
Works like a charm for me in EXT:news setups! -
Georg Ringer voted on patch set 6 V +1 CR +1 11/24/22, 11:04
-
Georg Ringer uploaded patch set 7
CR +1V +111/24/22, 12:43 -
Georg Ringer uploaded patch set 8 11/24/22, 12:44
-
Georg Ringer commented on patch set 8 11/24/22, 12:45
sorry pushed an older changeset by mistake :/ -
core-ci voted on patch set 7 V +1 11/24/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34168
-
core-ci voted on patch set 8 V +1 11/24/22, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34170
-
Stefan Froemken voted on patch set 8 V +1 CR +1 11/24/22, 13:03
-
Stefan Bürk voted on patch set 8 V +1 CR +1 11/24/22, 17:22
-
Stefan Bürk voted on patch set 8 V +2 CR +2 11/24/22, 17:24
-
Stefan Bürk commented on patch set 8 11/24/22, 17:24
Feature-99053-AddRouteAspectFallbackValueHandling.rst:49ReplyDone -
Stefan Bürk merged patch set 9 11/24/22, 17:24