76547[FEATURE] Add submodule for filemounts
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php2+43 −3
- typo3/sysext/beuser/Classes/Domain/Model/FileMount.phpnew+155 −0
- typo3/sysext/beuser/Classes/Domain/Repository/FileMountRepository.phpnew+37 −0
- typo3/sysext/beuser/Configuration/Backend/Modules.php+1 −0
- typo3/sysext/beuser/Configuration/Extbase/Persistence/Classes.php2+3 −0
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf+24 −0
- typo3/sysext/beuser/Resources/Private/Partials/Filemount/IndexListRow.html4new+68 −0
- typo3/sysext/beuser/Resources/Private/Partials/Filemount/NoFilemounts.html2new+28 −0
- typo3/sysext/beuser/Resources/Private/Partials/Filemount/PaginatedList.htmlnew+29 −0
- typo3/sysext/beuser/Resources/Private/Partials/Filemount/TotalFilemounts.htmlnew+15 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Filemounts.htmlnew+17 −0
- typo3/sysext/beuser/Tests/Unit/Domain/Repository/FileMountRepositoryTest.phpnew+32 −0
- typo3/sysext/beuser/README.rst+3 −0
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-99038-SubmoduleForFilemountsInBeUsermodule.rst2new+25 −0
Review log 2334
Show 59 earlier messages
-
Marcus Schwemer uploaded patch set 1 11/10/22, 16:08
-
core-ci voted on patch set 1 V -1 11/10/22, 16:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33518
-
Marcus Schwemer uploaded patch set 2 11/11/22, 08:10
-
core-ci voted on patch set 2 V -1 11/11/22, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33549
-
Marcus Schwemer uploaded patch set 3 11/11/22, 08:57
-
Marcus Schwemer uploaded patch set 4 11/11/22, 08:58
-
core-ci voted on patch set 3 V -1 11/11/22, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33553
-
core-ci voted on patch set 4 V +1 11/11/22, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33554
-
Susi Moog commented on patch set 4 V -1 11/11/22, 10:13
Already very nice, just a small improvement: if you only have two filemounts, there is no visual separator between the second line and the footer, which looks weird.
-
Marcus Schwemer uploaded patch set 5 11/11/22, 17:58
-
core-ci voted on patch set 5 V -1 11/11/22, 18:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33601
-
Marcus Schwemer uploaded patch set 6 11/11/22, 18:06
-
core-ci voted on patch set 6 V +1 11/11/22, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33602
-
Benni Mack uploaded patch set 7 11/11/22, 22:18
-
Benni Mack commented on patch set 7 V +1 CR +1 11/11/22, 22:26
Pagination is now gone :) I think however, that the patch is OK-ish. Anyone care to fix the pagination / divider thingy Susi mentioned? -
Benni Mack commented on patch set 7 11/11/22, 22:26
And: Thank you Marcus! -
core-ci voted on patch set 7 V +1 11/11/22, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33604
-
Marcus Schwemer commented on patch set 7 11/12/22, 09:10
Reply
Pagination is still there. It is only shown, if there are more 50 Elements (typo3/sysext/beuser/Classes/Controller/BackendUserController.php Line 493). I took also care of the divider thing. It is there only for filemounts. For the other submodules, I will take cake of that in other commits (Issues are already created) -
Marcus Schwemer uploaded patch set 8 11/12/22, 09:25
-
Marcus Schwemer commented on patch set 8 11/12/22, 09:27
Last patchset adds links to the filemounts in filelist module -
Marcus Schwemer uploaded patch set 9 11/12/22, 09:29
-
Marcus Schwemer commented on patch set 9 11/12/22, 09:30
Re-added your changes, Benni. I have not seen them before. Sorry. -
core-ci voted on patch set 8 V +1 11/12/22, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33616
-
Marcus Schwemer updated the commit message in patch set 10 11/12/22, 09:37
-
core-ci voted on patch set 9 V +1 11/12/22, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33618
-
core-ci voted on patch set 10 V +1 11/12/22, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33619
-
Stefan Bürk commented on patch set 10 11/13/22, 01:47
BackendUserController.php:588superflous empty line. can be removedClasses.php:53Wrong "indentation" here. We uses 4-space indentation in core. 2 spaces missing. PHPStorm reformat should do the trick, as this is defined per .editorconfig.IndexListRow.html:47Can also chopped to a new line as the other attributes, having one attribute per line and not mixed countsIndexListRow.html:52Would suggest to move and align the ending tag char on new lineNoFilemounts.html:18Would suggest to move the end-tag char to new lineFeature-99038-SubmoduleForFilemountsInBeUsermodule.rst:5"=" line must have the same length as the title text. Also, ReST filename does not match the title line. This is normally aligned. So, filename should be renamed also. -
Benni Mack uploaded patch set 11 11/14/22, 08:00
-
Benni Mack commented on patch set 10 11/14/22, 08:00
BackendUserController.php:588ReplyDoneClasses.php:53ReplyDoneIndexListRow.html:47ReplyDoneIndexListRow.html:52ReplyDoneNoFilemounts.html:18ReplyDoneFeature-99038-SubmoduleForFilemountsInBeUsermodule.rst:5ReplyDone -
Benni Mack voted on patch set 11 CR +1 11/14/22, 08:00
-
core-ci voted on patch set 11 V +1 11/14/22, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33689
-
Susi Moog voted on patch set 11 V +1 CR +1 11/14/22, 08:10
-
Benni Mack voted on patch set 11 V +2 CR +2 11/14/22, 08:16
-
Benni Mack merged patch set 12 11/14/22, 08:17