Review main Merged

76547[FEATURE] Add submodule for filemounts

Marcus Schwemer CR +2 V +2 Hard +480 −3 updated 11/14/22, 08:17

Commit message

Adds a submodule to the beuser module, which provides an
overview over all filemounts and allows them to modify,
hide, delete and add those.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 2334

Show 59 earlier messages
  1. Marcus Schwemer uploaded patch set 1 11/10/22, 16:08

  2. core-ci voted on patch set 1 V -1 11/10/22, 16:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33518

  3. Marcus Schwemer uploaded patch set 2 11/11/22, 08:10

  4. core-ci voted on patch set 2 V -1 11/11/22, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33549

  5. Marcus Schwemer uploaded patch set 3 11/11/22, 08:57

  6. Marcus Schwemer uploaded patch set 4 11/11/22, 08:58

  7. core-ci voted on patch set 3 V -1 11/11/22, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33553

  8. core-ci voted on patch set 4 V +1 11/11/22, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33554

  9. Susi Moog commented on patch set 4 V -1 11/11/22, 10:13

    Already very nice, just a small improvement: if you only have two filemounts, there is no visual separator between the second line and the footer, which looks weird.
  1. Marcus Schwemer uploaded patch set 5 11/11/22, 17:58

  2. core-ci voted on patch set 5 V -1 11/11/22, 18:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33601

  3. Marcus Schwemer uploaded patch set 6 11/11/22, 18:06

  4. core-ci voted on patch set 6 V +1 11/11/22, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33602

  5. Benni Mack uploaded patch set 7 11/11/22, 22:18

  6. Benni Mack commented on patch set 7 V +1 CR +1 11/11/22, 22:26

    Pagination is now gone :) I think however, that the patch is OK-ish. Anyone care to fix the pagination / divider thingy Susi mentioned?
  7. Benni Mack commented on patch set 7 11/11/22, 22:26

    And: Thank you Marcus!
  8. core-ci voted on patch set 7 V +1 11/11/22, 22:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33604

  9. Marcus Schwemer commented on patch set 7 11/12/22, 09:10

    Reply

    Pagination is still there. It is only shown, if there are more 50 Elements (typo3/sysext/beuser/Classes/Controller/BackendUserController.php Line 493). I took also care of the divider thing. It is there only for filemounts. For the other submodules, I will take cake of that in other commits (Issues are already created)
  10. Marcus Schwemer uploaded patch set 8 11/12/22, 09:25

  11. Marcus Schwemer commented on patch set 8 11/12/22, 09:27

    Last patchset adds links to the filemounts in filelist module
  12. Marcus Schwemer uploaded patch set 9 11/12/22, 09:29

  13. Marcus Schwemer commented on patch set 9 11/12/22, 09:30

    Re-added your changes, Benni. I have not seen them before. Sorry.
  14. core-ci voted on patch set 8 V +1 11/12/22, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33616

  15. Marcus Schwemer updated the commit message in patch set 10 11/12/22, 09:37

  16. core-ci voted on patch set 9 V +1 11/12/22, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33618

  17. core-ci voted on patch set 10 V +1 11/12/22, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33619

  18. Stefan Bürk commented on patch set 10 11/13/22, 01:47

    BackendUserController.php:588

    superflous empty line. can be removed

    Classes.php:53

    Wrong "indentation" here. We uses 4-space indentation in core. 2 spaces missing. PHPStorm reformat should do the trick, as this is defined per .editorconfig.

    IndexListRow.html:47

    Can also chopped to a new line as the other attributes, having one attribute per line and not mixed counts

    IndexListRow.html:52

    Would suggest to move and align the ending tag char on new line

    NoFilemounts.html:18

    Would suggest to move the end-tag char to new line

    Feature-99038-SubmoduleForFilemountsInBeUsermodule.rst:5

    "=" line must have the same length as the title text. Also, ReST filename does not match the title line. This is normally aligned. So, filename should be renamed also.
  19. Benni Mack uploaded patch set 11 11/14/22, 08:00

  20. Benni Mack commented on patch set 10 11/14/22, 08:00

    BackendUserController.php:588 Reply

    Done

    Classes.php:53 Reply

    Done

    IndexListRow.html:47 Reply

    Done

    IndexListRow.html:52 Reply

    Done

    NoFilemounts.html:18 Reply

    Done

    Feature-99038-SubmoduleForFilemountsInBeUsermodule.rst:5 Reply

    Done
  21. Benni Mack voted on patch set 11 CR +1 11/14/22, 08:00

  22. core-ci voted on patch set 11 V +1 11/14/22, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33689

  23. Susi Moog voted on patch set 11 V +1 CR +1 11/14/22, 08:10

  24. Benni Mack voted on patch set 11 V +2 CR +2 11/14/22, 08:16

  25. Benni Mack merged patch set 12 11/14/22, 08:17