76550[FEATURE] Add new possibilities to modify DefaultUploadFolder settings
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+14 −7
- typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php+4 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+7 −2
- typo3/sysext/core/Classes/Resource/Event/AfterDefaultUploadFolderWasResolvedEvent.phpnew+59 −0
- typo3/sysext/core/Classes/Resource/DefaultUploadFolderResolver.php4new+122 −0
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Deprecation-83608-BackendUsersGetDefaultUploadFolderHook.rstnew+45 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-83608-PageTSconfigSettingOptionsdefaultUploadFolderAdded.rstnew+36 −0
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-83608-PSR-14EventToModifyResolvedDefaultUploadFolder.rstnew+61 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DefaultUploadFolderResolver/be_users.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DefaultUploadFolderResolver/pages.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/Resource/DefaultUploadFolderResolverTest.phpnew+200 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
Review log 2946
Show 1221 earlier messages
-
Andreas Nedbal uploaded patch set 1 11/10/22, 22:00
-
Andreas Nedbal updated the commit message in patch set 2 11/10/22, 22:01
-
core-ci voted on patch set 1 V -1 11/10/22, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33535
-
core-ci voted on patch set 2 V -1 11/10/22, 22:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33536
-
Benni Mack uploaded patch set 3 11/11/22, 08:12
-
core-ci voted on patch set 3 V -1 11/11/22, 08:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33550
-
Andreas Nedbal uploaded patch set 4 11/11/22, 09:27
-
core-ci voted on patch set 4 V -1 11/11/22, 09:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33555
-
Andreas Nedbal uploaded patch set 5 11/11/22, 09:52
-
core-ci voted on patch set 5 V +1 11/11/22, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33557
-
Andreas Nedbal uploaded patch set 6 11/11/22, 13:05
-
core-ci voted on patch set 6 V +1 11/11/22, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33586
-
Andreas Nedbal uploaded patch set 7 11/11/22, 13:41
-
core-ci voted on patch set 7 V +1 11/11/22, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33587
-
Georg Ringer commented on patch set 7 11/14/22, 09:23
I know it is just a WIP yet ;) please also don't forget the rst for the event! thanks!DefaultUploadFolderResolver.php:38please add the types: int $pid = null, string $table = null, string $field = null -
Andreas Nedbal uploaded patch set 8
V +111/28/22, 11:26 -
core-ci voted on patch set 8 V +1 11/28/22, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34314
-
Andreas Nedbal commented on patch set 8 11/28/22, 11:44
DefaultUploadFolderResolver.php:38ReplyDone, added the types! -
Benni Mack updated the commit message in patch set 9
V +112/01/22, 22:53 -
core-ci voted on patch set 9 V +1 12/01/22, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34530
-
Andreas Nedbal uploaded patch set 10
V +112/02/22, 09:17
-
core-ci voted on patch set 10 V -1 12/02/22, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34543
-
Andreas Nedbal uploaded patch set 11
V -112/02/22, 09:29 -
core-ci voted on patch set 11 V +1 12/02/22, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34544
-
Chris Müller uploaded patch set 12
V +112/04/22, 18:09 -
Chris Müller commented on patch set 12 12/04/22, 18:12
Just a question: As the new PSR-14 event replaces the hook "getDefaultUploadFolder", will the hook be deprecated? And if yes, then we need also a deprecation rst. -
core-ci voted on patch set 12 V +1 12/04/22, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34608
-
Benni Mack commented on patch set 12 12/04/22, 20:06
Reply
I think we should deprecate the whole method in a separate patch -
Benni Mack commented on patch set 13
V +112/06/22, 10:49Published edit on patch set 12. -
core-ci voted on patch set 13 V +1 12/06/22, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34708
-
Jörg Bösche voted on patch set 13 CR +1 01/13/23, 09:51
-
Chris Müller uploaded patch set 14
CR +1V +102/08/23, 17:54 -
core-ci voted on patch set 14 V +1 02/08/23, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37402
-
Benni Mack uploaded patch set 15
V +103/22/23, 21:36 -
Benni Mack uploaded patch set 16 03/22/23, 21:42
-
Benni Mack voted on patch set 16 V +1 CR +1 03/22/23, 21:42
-
core-ci voted on patch set 15 V +1 03/22/23, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39419
-
core-ci voted on patch set 16 V +1 03/22/23, 21:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39420
-
Guido Schmechel commented on patch set 16 03/22/23, 22:58
BackendUserAuthentication.php:1610FormEngineDefaultUploadFolderResolver.php:107Do we need a $storage->isOnline() check? I think especially about remote storages. Although it has also been used without isOnline() up to now. ;-) -
Georg Ringer uploaded patch set 17
CR +1V +103/23/23, 06:26 -
Georg Ringer commented on patch set 17 V +1 CR +1 03/23/23, 06:26
BackendUserAuthentication.php:1610ReplyDone -
core-ci voted on patch set 17 V +1 03/23/23, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39441
-
Benni Mack commented on patch set 17 V +2 CR +2 03/23/23, 08:34
DefaultUploadFolderResolver.php:107Replylet's leave it out for the time being. -
Benni Mack merged patch set 18 03/23/23, 08:34
-
Stephan Großberndt commented on patch set 18 03/23/23, 09:16
Does this make https://github.com/beechit/default_upload_folder#readme obsolete completely? The example in the feature.rst is only for a page, but using typoscript conditions it might also be used to configure a different upload folder per column of a table of an extension as well? -
Benni Mack commented on patch set 18 03/23/23, 09:59
Reply
nope. all features of the extension are not incorporated yet, but I think this change can easily be added in a followup, in case you're interested ;)