Review main Merged

76552[TASK] Avoid TypoScriptParser->getVal()

Christian Kuhn CR +2 V +2 Normal +64 −64 updated 11/11/22, 12:54

Commit message

To further reduce usages of old TypoScriptParser,
the "resolve '=<' reference operator" logic in
ContentObjectRenderer is streamlined and avoids
using the TypoScriptParser->getVal() helper method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1115

  1. Christian Kuhn uploaded patch set 1 11/11/22, 10:00

  2. core-ci voted on patch set 1 V -1 11/11/22, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33558

  3. Oliver Klee commented on patch set 1 11/11/22, 10:22

    ContentObjectRenderer.php:85

    Nitpick (for the next revision): Comma missing after "so"
  4. Christian Kuhn uploaded patch set 2 11/11/22, 11:30

  5. Christian Kuhn commented on patch set 2 11/11/22, 11:31

    ContentObjectRenderer.php:85 Reply

    Done
  6. Christian Kuhn uploaded patch set 3 11/11/22, 11:34

  7. core-ci voted on patch set 2 V -1 11/11/22, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33573

  8. core-ci voted on patch set 3 V -1 11/11/22, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33574

  9. Christian Kuhn uploaded patch set 4 11/11/22, 11:48

  10. core-ci voted on patch set 4 V +1 11/11/22, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33575

  11. Benni Mack commented on patch set 4 V +1 CR +1 11/11/22, 12:29

    Incredible, didn't think it would be that simple.
  12. Stefan Bürk voted on patch set 4 CR +1 11/11/22, 12:44

  13. Stefan Bürk voted on patch set 4 V +1 11/11/22, 12:48

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 11/11/22, 12:50

  15. Christian Kuhn merged patch set 5 11/11/22, 12:54