Review main Merged

76553[FEATURE] Introduce native JSON database field type support

Stefan Bürk CR +2 V +2 Hard +510 −133 updated 11/22/22, 21:42

Commit message

The patch adds native JSON database field type.

This allows to define a JSON database field in extension
`ext_tables.sql` files, example:

CREATE TABLE tx_myextension_domain_model_book (
    title varchar(200) DEFAULT '',
    contents json
);

The methods `insert()`, `bulkInsert()` and `update()` in
class `\TYPO3\CMS\Core\Database\Connection` now
convert provided data values to their database counterpart
as define by doctrine/dbal. For json fields, values can be
provides as array and will be automatically json_encode()'ed.

The patch:
* Ensures php to database value conversion in fascade connection
  methods `insert()`, 'bulkInsert()` and `update()`
* Map JSON type from ext_tables.sql to doctrine/dbal JSON Type
* Remove platform specific automatic type determination in core
  DataHandler due to generic handling in Connection fascade class
* doctrine/dbal DateTimeType, DateType and TimeType are overriden
  to allow string as php value for converting to database

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 17

Review log 3659

Show 2034 earlier messages
  1. Stefan Bürk uploaded patch set 1 11/11/22, 10:51

  2. core-ci voted on patch set 1 V -1 11/11/22, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33566

  3. Stefan Bürk uploaded patch set 2 11/11/22, 11:14

  4. core-ci voted on patch set 2 V -1 11/11/22, 11:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33571

  5. Benni Mack uploaded patch set 3 11/11/22, 12:55

  6. core-ci voted on patch set 3 V -1 11/11/22, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33582

  7. core-ci voted on patch set 2 V -1 11/11/22, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33571

  8. Stefan Bürk uploaded patch set 4 11/11/22, 22:22

  9. Benni Mack commented on patch set 4 V +1 CR +1 11/11/22, 22:27

    If this goes green, you have my votes!
  10. core-ci voted on patch set 4 V +1 11/11/22, 22:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33605

  11. Stefan Bürk commented on patch set 4 11/11/22, 22:35

    Reply

    Thanks. But have to remove [WIP] before, so revoting is needed anyway.
  12. Stefan Bürk updated the commit message in patch set 5 11/11/22, 22:39

  13. Benni Mack voted on patch set 5 V +1 CR +1 11/11/22, 22:39

  14. core-ci voted on patch set 5 V +1 11/11/22, 22:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33606

  15. Stefan Bürk commented on patch set 5 11/11/22, 22:55

  16. core-ci voted on patch set 5 V -1 11/12/22, 00:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33608

  17. core-ci commented on patch set 5 11/12/22, 00:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33608

  18. Stefan Bürk voted on patch set 5 CR -1 11/12/22, 00:39

  19. Stefan Bürk uploaded patch set 6 11/12/22, 17:43

  20. Stefan Bürk voted on patch set 6 CR -1 11/12/22, 17:43

  21. core-ci voted on patch set 6 V +1 11/12/22, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33647

  22. Stefan Bürk commented on patch set 6 11/12/22, 17:53

  23. core-ci commented on patch set 6 11/12/22, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33650

  24. Stefan Bürk uploaded patch set 7 CR -1 V +1 11/19/22, 23:15

  25. Stefan Bürk voted on patch set 7 CR -1 11/19/22, 23:15

  26. core-ci voted on patch set 7 V +1 11/19/22, 23:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33975

  27. Stefan Bürk uploaded patch set 8 CR -1 V +1 11/19/22, 23:33

  28. Stefan Bürk uploaded patch set 9 11/19/22, 23:38

  29. Stefan Bürk voted on patch set 9 CR -1 11/19/22, 23:38

  30. Stefan Bürk uploaded patch set 10 CR -1 11/19/22, 23:53

  31. Stefan Bürk voted on patch set 10 CR -1 11/19/22, 23:53

  32. core-ci voted on patch set 10 V -1 11/20/22, 00:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33978

  33. core-ci commented on patch set 10 11/20/22, 00:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33978

  34. core-ci commented on patch set 10 11/20/22, 00:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33978

  1. Stefan Bürk uploaded patch set 11 CR -1 V -1 11/20/22, 02:24

  2. core-ci voted on patch set 11 V -1 11/20/22, 02:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33981

  3. Stefan Bürk uploaded patch set 12 V -1 11/20/22, 02:49

  4. Stefan Bürk voted on patch set 12 CR -1 11/20/22, 02:50

  5. Stefan Bürk uploaded patch set 13 CR -1 11/20/22, 03:08

  6. core-ci voted on patch set 12 V +1 11/20/22, 03:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33982

  7. Stefan Bürk uploaded patch set 14 11/20/22, 03:16

  8. Stefan Bürk voted on patch set 14 CR -1 11/20/22, 03:16

  9. core-ci voted on patch set 14 V -1 11/20/22, 03:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33985

  10. Stefan Bürk uploaded patch set 15 CR -1 V -1 11/20/22, 20:41

  11. Stefan Bürk voted on patch set 15 CR -1 11/20/22, 20:41

  12. core-ci voted on patch set 15 V +1 11/20/22, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34018

  13. Stefan Bürk uploaded patch set 16 CR -1 V +1 11/22/22, 19:25

  14. core-ci voted on patch set 16 V +1 11/22/22, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34076

  15. core-ci commented on patch set 16 11/22/22, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34077

  16. Stefan Bürk uploaded patch set 17 V +1 11/22/22, 20:23

  17. core-ci voted on patch set 17 V +1 11/22/22, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34079

  18. Christian Kuhn uploaded patch set 18 V +1 11/22/22, 21:00

  19. Christian Kuhn uploaded patch set 19 11/22/22, 21:01

  20. Christian Kuhn voted on patch set 19 V +1 CR +1 11/22/22, 21:02

  21. core-ci voted on patch set 18 V +1 11/22/22, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34080

  22. core-ci voted on patch set 19 V +1 11/22/22, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34081

  23. Benni Mack voted on patch set 19 V +1 CR +1 11/22/22, 21:21

  24. Stefan Bürk voted on patch set 19 V +2 CR +2 11/22/22, 21:23

  25. Stefan Bürk merged patch set 20 11/22/22, 21:42