Review main Merged

76564[TASK] Require Doctrine DBAL 3.5+

Benni Mack CR +2 V +2 Easy +23 −23 updated 11/13/22, 13:06

Commit message

The latest Doctrine DBAL 3.5 is similar
to Doctrine DBAL 4, which is what we
want to use in the future.

Used command(s):

> composer req "doctrine/dbal":"^3.5.1" \
    --no-update -d typo3/sysext/core
> composer req "doctrine/dbal":"^3.5.1" \
    --no-update -d typo3/sysext/install
> composer req "doctrine/dbal":"^3.5.1" \
    --no-update -d typo3/sysext/redirects
> composer req "doctrine/dbal":"^3.5.1"

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 811

  1. Benni Mack uploaded patch set 1 11/11/22, 22:39

  2. core-ci voted on patch set 1 V -1 11/11/22, 22:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33607

  3. Stefan Bürk uploaded patch set 2 11/12/22, 16:12

  4. core-ci voted on patch set 2 V +1 11/12/22, 16:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33639

  5. Oliver Klee voted on patch set 2 CR +1 11/12/22, 16:33

  6. Oliver Klee voted on patch set 2 V +1 11/12/22, 16:55

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 11/12/22, 17:51

  8. Christian Kuhn commented on patch set 2 11/13/22, 12:23

    started nightly with this and will merge when green.
  9. core-ci commented on patch set 2 11/13/22, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33673

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 11/13/22, 13:06

  11. Christian Kuhn merged patch set 3 11/13/22, 13:06