Review main Merged

76565[TASK] Deprecate old TypoScriptParser

Christian Kuhn CR +2 V +2 Expert +1417 −231 updated 12/08/22, 12:03

Commit message

The main goal of this patch is to avoid last usages
of old TypoScriptParser and to substitute it with
usages of the new parser approach.

A couple of side usages have to be adapted, but the
main work is to establish new factories for UserTsConfig
and PageTsConfig while deprecating the former approach
and adding functional test coverage to the factories.

BackendUtility::getPagesTSconfig() is still the main
API to retrieve PageTsConfig, for UserTsConfig it is
$backendUser->getTSConfig(). The new API is thus
considered @internal, at least for now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 56

Show 36 more files

Review log 63110

Show 4885 earlier messages
  1. Christian Kuhn uploaded patch set 1 11/12/22, 07:58

  2. core-ci voted on patch set 1 V +1 11/12/22, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33614

  3. Benni Mack commented on patch set 1 11/12/22, 08:25

    TypoScriptStringFactory.php:24

    could you please provide some additional info what this class does and when to use it?
  4. Christian Kuhn uploaded patch set 2 11/12/22, 09:29

  5. Christian Kuhn commented on patch set 2 11/12/22, 09:30

    TypoScriptStringFactory.php:24 Reply

    I will. Of course ;) Patch is currently a bit experimental and I want to see how the Factories evolve before documenting them.
  6. core-ci voted on patch set 2 V -1 11/12/22, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33617

  7. core-ci voted on patch set 2 V +1 11/12/22, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33617

  8. Christian Kuhn uploaded patch set 3 11/12/22, 10:21

  9. core-ci voted on patch set 3 V -1 11/12/22, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33623

  10. Oliver Klee commented on patch set 3 11/12/22, 10:56

    NoopEventDispatcher.php:28

    Yay! Could we also have this in 11.5? This will make life of ext devs a lot easier.
  11. Christian Kuhn uploaded patch set 4 11/12/22, 11:31

  12. Christian Kuhn commented on patch set 3 11/12/22, 11:35

    NoopEventDispatcher.php:28 Reply

    can be done. let's do this as single patch.
  13. core-ci voted on patch set 4 V +1 11/12/22, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33626

  14. Oliver Klee commented on patch set 4 11/12/22, 11:56

    TreeFromLineStreamBuilder.php:60

    /** @var 'constants'|'setup'|'other' */
  15. Christian Kuhn uploaded patch set 5 11/12/22, 12:14

  16. Christian Kuhn commented on patch set 5 11/12/22, 12:16

    TreeFromLineStreamBuilder.php:60 Reply

    Done
  17. Christian Kuhn uploaded patch set 6 11/12/22, 12:20

  18. core-ci voted on patch set 5 V +1 11/12/22, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33627

  19. core-ci voted on patch set 6 V +1 11/12/22, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33628

  20. Oliver Klee commented on patch set 6 11/12/22, 12:29

    SysTemplateTreeBuilder.php:81

    The "string" should not be here as this is already implicit per the literals. Documentation for this: https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants

    TreeFromLineStreamBuilder.php:59

    The "string" should not be here as this is already implicit per the literals. Documentation for this: https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants
  21. Christian Kuhn uploaded patch set 7 11/12/22, 12:32

  22. Christian Kuhn commented on patch set 7 11/12/22, 12:33

    SysTemplateTreeBuilder.php:81 Reply

    no. phpstan stumbles if that is removed.

    TreeFromLineStreamBuilder.php:59 Reply

    no. phpstand stumbles if that is removed.
  23. core-ci voted on patch set 7 V +1 11/12/22, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33629

  24. Christian Kuhn uploaded patch set 8 11/14/22, 07:44

  25. core-ci voted on patch set 8 V +1 11/14/22, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33688

  26. Oliver Klee commented on patch set 8 11/14/22, 09:26

    SysTemplateTreeBuilder.php:81

    We still need to modify those (and the in_array calls) like in the patch I've sent via Slack.
  27. Christian Kuhn uploaded patch set 9 11/14/22, 10:12

  28. Christian Kuhn commented on patch set 8 11/14/22, 10:12

    SysTemplateTreeBuilder.php:81 Reply

    Done
  29. core-ci voted on patch set 9 V +1 11/14/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33695

  30. Christian Kuhn uploaded patch set 10 11/14/22, 13:24

  31. Christian Kuhn uploaded patch set 11 11/14/22, 13:29

  32. core-ci voted on patch set 10 V -1 11/14/22, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33704

  33. core-ci voted on patch set 11 V -1 11/14/22, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33705

  34. core-ci commented on patch set 11 11/14/22, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33705

  35. Christian Kuhn uploaded patch set 12 11/15/22, 08:46

  36. core-ci voted on patch set 12 V +1 11/15/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33740

  37. Christian Kuhn uploaded patch set 13 11/15/22, 12:47

  38. Christian Kuhn uploaded patch set 14 11/15/22, 12:49

  39. core-ci voted on patch set 13 V -1 11/15/22, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33751

  40. core-ci voted on patch set 14 V -1 11/15/22, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33752

  41. Christian Kuhn uploaded patch set 15 11/15/22, 13:43

  42. core-ci voted on patch set 15 V +1 11/15/22, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33758

  43. Christian Kuhn uploaded patch set 16 11/15/22, 14:38

  44. core-ci voted on patch set 16 V +1 11/15/22, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33761

  45. Christian Kuhn uploaded patch set 17 11/15/22, 18:43

  46. core-ci voted on patch set 17 V +1 11/15/22, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33777

  47. Christian Kuhn uploaded patch set 18 11/17/22, 13:06

  48. core-ci voted on patch set 18 V +1 11/17/22, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33869

  49. Christian Kuhn uploaded patch set 19 11/17/22, 14:25

  50. core-ci voted on patch set 19 V -1 11/17/22, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33872

  51. Christian Kuhn uploaded patch set 20 11/17/22, 14:36

  52. core-ci voted on patch set 20 V -1 11/17/22, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33873

  53. Christian Kuhn uploaded patch set 21 11/17/22, 14:51

  54. core-ci voted on patch set 21 V +1 11/17/22, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33875

  55. Christian Kuhn uploaded patch set 22 11/17/22, 15:01

  56. core-ci voted on patch set 22 V +1 11/17/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33876

  57. Christian Kuhn rebased onto patch set 23 11/17/22, 15:49

  58. core-ci voted on patch set 23 V +1 11/17/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33879

  59. Christian Kuhn commented on patch set 23 11/17/22, 16:27

    hmm. not sure about the attribute anymore after i tried getting rid of BU:getPagesTsConfig($id) ... need to have a chat with benni again, we may want to change strategy again.
  60. Christian Kuhn uploaded patch set 24 11/17/22, 16:52

  61. core-ci voted on patch set 24 V -1 11/17/22, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33880

  62. Christian Kuhn uploaded patch set 25 V -1 11/30/22, 08:08

  63. Christian Kuhn uploaded patch set 26 11/30/22, 08:15

  64. core-ci voted on patch set 26 V +1 11/30/22, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34393

  65. core-ci voted on patch set 25 V -1 11/30/22, 08:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34392

  66. Christian Kuhn uploaded patch set 27 V +1 12/01/22, 11:24

  67. Christian Kuhn uploaded patch set 28 12/01/22, 11:35

  68. core-ci voted on patch set 27 V -1 12/01/22, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34472

  69. core-ci voted on patch set 28 V -1 12/01/22, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34476

  70. Christian Kuhn uploaded patch set 29 V -1 12/01/22, 12:09

  71. Christian Kuhn uploaded patch set 30 12/01/22, 12:27

  72. core-ci voted on patch set 29 V -1 12/01/22, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34483

  73. Christian Kuhn uploaded patch set 31 12/01/22, 12:41

  74. core-ci voted on patch set 30 V -1 12/01/22, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34488

  75. Christian Kuhn uploaded patch set 32 12/01/22, 12:48

  76. core-ci voted on patch set 31 V -1 12/01/22, 12:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34490

  77. Christian Kuhn uploaded patch set 33 12/01/22, 13:03

  78. core-ci voted on patch set 32 V -1 12/01/22, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34491

  79. core-ci voted on patch set 33 V +1 12/01/22, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34495

  80. Christian Kuhn uploaded patch set 34 V +1 12/06/22, 14:27

  81. core-ci voted on patch set 34 V +1 12/06/22, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34722

  82. Christian Kuhn uploaded patch set 35 V +1 12/06/22, 15:25

  83. core-ci voted on patch set 35 V +1 12/06/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34724

  84. Christian Kuhn uploaded patch set 36 V +1 12/06/22, 16:00

  85. Christian Kuhn uploaded patch set 37 12/06/22, 16:08

  1. core-ci voted on patch set 36 V +1 12/06/22, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34726

  2. Christian Kuhn uploaded patch set 38 12/06/22, 16:13

  3. core-ci voted on patch set 37 V +1 12/06/22, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34727

  4. Christian Kuhn uploaded patch set 39 12/06/22, 16:16

  5. core-ci voted on patch set 38 V +1 12/06/22, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34728

  6. core-ci voted on patch set 39 V +1 12/06/22, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34729

  7. Christian Kuhn uploaded patch set 40 V +1 12/06/22, 17:49

  8. core-ci voted on patch set 40 V -1 12/06/22, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34730

  9. Christian Kuhn uploaded patch set 41 V -1 12/06/22, 17:58

  10. Christian Kuhn commented on patch set 40 12/06/22, 17:58

    this patch drives me nuts ... hope to finish it soon.
  11. core-ci voted on patch set 41 V +1 12/06/22, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34731

  12. Christian Kuhn uploaded patch set 42 V +1 12/07/22, 15:11

  13. core-ci voted on patch set 42 V +1 12/07/22, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34764

  14. Christian Kuhn uploaded patch set 43 V +1 12/07/22, 16:52

  15. Christian Kuhn uploaded patch set 44 12/07/22, 16:57

  16. core-ci voted on patch set 43 V +1 12/07/22, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34768

  17. core-ci voted on patch set 44 V +1 12/07/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34769

  18. Christian Kuhn rebased onto patch set 45 V +1 12/07/22, 17:24

  19. core-ci voted on patch set 45 V +1 12/07/22, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34771

  20. Anja Leichsenring commented on patch set 45 V +1 CR +1 12/07/22, 19:21

    played around with my testing instance for quite a while, no issue turned up. I think this is good to go. Thank you for all the effort, this makes the TYPO3 world a little bit better again.
  21. Stefan Bürk voted on patch set 45 V +1 CR +1 12/08/22, 10:01

  22. Benni Mack commented on patch set 45 CR -2 12/08/22, 10:32

    reviewing...
  23. Benni Mack voted on patch set 45 CR +1 12/08/22, 11:57

  24. Christian Kuhn voted on patch set 45 V +2 CR +2 12/08/22, 12:03

  25. Christian Kuhn merged patch set 46 12/08/22, 12:03