76565[TASK] Deprecate old TypoScriptParser
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 56
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+1 −6
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+30 −15
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+1 −7
- typo3/sysext/backend/Classes/View/BackendViewFactory.php+9 −1
- typo3/sysext/backend/Configuration/Services.yaml+0 −4
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+39 −47
- typo3/sysext/core/Classes/Configuration/Event/ModifyLoadedPageTsConfigEvent.php+5 −24
- typo3/sysext/core/Classes/Configuration/Loader/PageTsConfigLoader.php+4 −0
- typo3/sysext/core/Classes/Configuration/Parser/PageTsConfigParser.php+4 −0
- typo3/sysext/core/Classes/Configuration/ExtensionConfiguration.php+1 −2
- typo3/sysext/core/Classes/Configuration/PageTsConfig.php+4 −0
- typo3/sysext/core/Classes/Package/AbstractServiceProvider.php+4 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Event/ModifyLoadedPageTsConfigEvent.phpnew+50 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/TsConfigInclude.phpnew+27 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.phpnew+190 −0
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+6 −2
- typo3/sysext/core/Classes/TypoScript/PageTsConfig.phpnew+46 −0
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.phpnew+132 −0
- typo3/sysext/core/Classes/TypoScript/TypoScriptStringFactory.php2+11 −5
- typo3/sysext/core/Classes/TypoScript/UserTsConfig.phpnew+46 −0
Show 36 more files
- typo3/sysext/core/Classes/TypoScript/UserTsConfigFactory.phpnew+63 −0
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+2 −6
- typo3/sysext/core/Classes/ServiceProvider.php+10 −1
- typo3/sysext/core/Configuration/Services.yaml+16 −0
- typo3/sysext/core/Documentation/Changelog/12.2/Deprecation-99120-DeprecateOldTypoScriptParser.rstnew+109 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_pagetsconfigfactory/Classes/EventListener/LegacyModifyLoadedPageTsConfig.phpnew+31 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_pagetsconfigfactory/Classes/EventListener/ModifyLoadedPageTsConfig.phpnew+28 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_pagetsconfigfactory/Configuration/TsConfig/tsconfig-includes.tsconfignew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_pagetsconfigfactory/Configuration/page.tsconfignew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_pagetsconfigfactory/Configuration/Services.yamlnew+16 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_typoscript_pagetsconfigfactory/ext_emconf.phpnew+21 −0
- typo3/sysext/core/Tests/Functional/TypoScript/Fixtures/pageTsConfigTestFixture.csvnew+3 −0
- typo3/sysext/core/Tests/Functional/TypoScript/Fixtures/userTsConfigTestFixture.csvnew+15 −0
- typo3/sysext/core/Tests/Functional/TypoScript/PageTsConfigFactoryTest.phpnew+224 −0
- typo3/sysext/core/Tests/Functional/TypoScript/TypoScriptStringFactoryTest.php+1 −7
- typo3/sysext/core/Tests/Functional/TypoScript/UserTsConfigFactoryTest.phpnew+104 −0
- typo3/sysext/core/Tests/FunctionalDeprecated/TypoScript/Parser/TypoScriptParserTest.phprenamed+1 −1
- typo3/sysext/core/Tests/Unit/TypoScript/Fixtures/ext_typoscript_setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/Unit/TypoScript/Fixtures/recursive_includes_setup.typoscriptdeleted+0 −1
- typo3/sysext/core/Tests/UnitDeprecated/Configuration/Loader/Fixtures/included.typoscriptrenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/Configuration/Loader/PageTsConfigLoaderTest.phprenamed+8 −11
- typo3/sysext/core/Tests/UnitDeprecated/Configuration/Parser/PageTsConfigParserTest.phprenamed+1 −1
- typo3/sysext/core/Tests/UnitDeprecated/TypoScript/Fixtures/badfilename.phprenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/TypoScript/Fixtures/recursive_includes_setup.typoscriptnew+1 −0
- typo3/sysext/core/Tests/UnitDeprecated/TypoScript/Fixtures/setup.typoscriptrenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/TypoScript/Parser/TypoScriptParserTest.phprenamed+47 −47
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+5 −0
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+33 −2
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+2 −3
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+23 −14
- typo3/sysext/info/Resources/Private/Language/InfoPageTsConfig.xlf+0 −6
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+25 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+7 −13
- typo3/sysext/linkvalidator/Resources/Private/Language/locallang.xlf+0 −3
- composer.json+2 −1
Review log 63110
Show 4885 earlier messages
-
Christian Kuhn uploaded patch set 1 11/12/22, 07:58
-
core-ci voted on patch set 1 V +1 11/12/22, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33614
-
Benni Mack commented on patch set 1 11/12/22, 08:25
-
Christian Kuhn uploaded patch set 2 11/12/22, 09:29
-
Christian Kuhn commented on patch set 2 11/12/22, 09:30
TypoScriptStringFactory.php:24ReplyI will. Of course ;) Patch is currently a bit experimental and I want to see how the Factories evolve before documenting them. -
core-ci voted on patch set 2 V -1 11/12/22, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33617
-
core-ci voted on patch set 2 V +1 11/12/22, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33617
-
Christian Kuhn uploaded patch set 3 11/12/22, 10:21
-
core-ci voted on patch set 3 V -1 11/12/22, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33623
-
Oliver Klee commented on patch set 3 11/12/22, 10:56
NoopEventDispatcher.php:28Yay! Could we also have this in 11.5? This will make life of ext devs a lot easier. -
Christian Kuhn uploaded patch set 4 11/12/22, 11:31
-
Christian Kuhn commented on patch set 3 11/12/22, 11:35
NoopEventDispatcher.php:28Replycan be done. let's do this as single patch. -
core-ci voted on patch set 4 V +1 11/12/22, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33626
-
Oliver Klee commented on patch set 4 11/12/22, 11:56
TreeFromLineStreamBuilder.php:60/** @var 'constants'|'setup'|'other' */ -
Christian Kuhn uploaded patch set 5 11/12/22, 12:14
-
Christian Kuhn commented on patch set 5 11/12/22, 12:16
TreeFromLineStreamBuilder.php:60ReplyDone -
Christian Kuhn uploaded patch set 6 11/12/22, 12:20
-
core-ci voted on patch set 5 V +1 11/12/22, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33627
-
core-ci voted on patch set 6 V +1 11/12/22, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33628
-
Oliver Klee commented on patch set 6 11/12/22, 12:29
SysTemplateTreeBuilder.php:81The "string" should not be here as this is already implicit per the literals. Documentation for this: https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constantsTreeFromLineStreamBuilder.php:59The "string" should not be here as this is already implicit per the literals. Documentation for this: https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants -
Christian Kuhn uploaded patch set 7 11/12/22, 12:32
-
Christian Kuhn commented on patch set 7 11/12/22, 12:33
SysTemplateTreeBuilder.php:81Replyno. phpstan stumbles if that is removed.TreeFromLineStreamBuilder.php:59Replyno. phpstand stumbles if that is removed. -
core-ci voted on patch set 7 V +1 11/12/22, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33629
-
Christian Kuhn uploaded patch set 8 11/14/22, 07:44
-
core-ci voted on patch set 8 V +1 11/14/22, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33688
-
Oliver Klee commented on patch set 8 11/14/22, 09:26
SysTemplateTreeBuilder.php:81We still need to modify those (and the in_array calls) like in the patch I've sent via Slack. -
Christian Kuhn uploaded patch set 9 11/14/22, 10:12
-
Christian Kuhn commented on patch set 8 11/14/22, 10:12
SysTemplateTreeBuilder.php:81ReplyDone -
core-ci voted on patch set 9 V +1 11/14/22, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33695
-
Christian Kuhn uploaded patch set 10 11/14/22, 13:24
-
Christian Kuhn uploaded patch set 11 11/14/22, 13:29
-
core-ci voted on patch set 10 V -1 11/14/22, 13:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33704
-
core-ci voted on patch set 11 V -1 11/14/22, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33705
-
core-ci commented on patch set 11 11/14/22, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33705
-
Christian Kuhn uploaded patch set 12 11/15/22, 08:46
-
core-ci voted on patch set 12 V +1 11/15/22, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33740
-
Christian Kuhn uploaded patch set 13 11/15/22, 12:47
-
Christian Kuhn uploaded patch set 14 11/15/22, 12:49
-
core-ci voted on patch set 13 V -1 11/15/22, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33751
-
core-ci voted on patch set 14 V -1 11/15/22, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33752
-
Christian Kuhn uploaded patch set 15 11/15/22, 13:43
-
core-ci voted on patch set 15 V +1 11/15/22, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33758
-
Christian Kuhn uploaded patch set 16 11/15/22, 14:38
-
core-ci voted on patch set 16 V +1 11/15/22, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33761
-
Christian Kuhn uploaded patch set 17 11/15/22, 18:43
-
core-ci voted on patch set 17 V +1 11/15/22, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33777
-
Christian Kuhn uploaded patch set 18 11/17/22, 13:06
-
core-ci voted on patch set 18 V +1 11/17/22, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33869
-
Christian Kuhn uploaded patch set 19 11/17/22, 14:25
-
core-ci voted on patch set 19 V -1 11/17/22, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33872
-
Christian Kuhn uploaded patch set 20 11/17/22, 14:36
-
core-ci voted on patch set 20 V -1 11/17/22, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33873
-
Christian Kuhn uploaded patch set 21 11/17/22, 14:51
-
core-ci voted on patch set 21 V +1 11/17/22, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33875
-
Christian Kuhn uploaded patch set 22 11/17/22, 15:01
-
core-ci voted on patch set 22 V +1 11/17/22, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33876
-
Christian Kuhn rebased onto patch set 23 11/17/22, 15:49
-
core-ci voted on patch set 23 V +1 11/17/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33879
-
Christian Kuhn commented on patch set 23 11/17/22, 16:27
hmm. not sure about the attribute anymore after i tried getting rid of BU:getPagesTsConfig($id) ... need to have a chat with benni again, we may want to change strategy again. -
Christian Kuhn uploaded patch set 24 11/17/22, 16:52
-
core-ci voted on patch set 24 V -1 11/17/22, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33880
-
Christian Kuhn uploaded patch set 25
V -111/30/22, 08:08 -
Christian Kuhn uploaded patch set 26 11/30/22, 08:15
-
core-ci voted on patch set 26 V +1 11/30/22, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34393
-
core-ci voted on patch set 25 V -1 11/30/22, 08:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34392
-
Christian Kuhn uploaded patch set 27
V +112/01/22, 11:24 -
Christian Kuhn uploaded patch set 28 12/01/22, 11:35
-
core-ci voted on patch set 27 V -1 12/01/22, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34472
-
core-ci voted on patch set 28 V -1 12/01/22, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34476
-
Christian Kuhn uploaded patch set 29
V -112/01/22, 12:09 -
Christian Kuhn uploaded patch set 30 12/01/22, 12:27
-
core-ci voted on patch set 29 V -1 12/01/22, 12:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34483
-
Christian Kuhn uploaded patch set 31 12/01/22, 12:41
-
core-ci voted on patch set 30 V -1 12/01/22, 12:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34488
-
Christian Kuhn uploaded patch set 32 12/01/22, 12:48
-
core-ci voted on patch set 31 V -1 12/01/22, 12:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34490
-
Christian Kuhn uploaded patch set 33 12/01/22, 13:03
-
core-ci voted on patch set 32 V -1 12/01/22, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34491
-
core-ci voted on patch set 33 V +1 12/01/22, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34495
-
Christian Kuhn uploaded patch set 34
V +112/06/22, 14:27 -
core-ci voted on patch set 34 V +1 12/06/22, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34722
-
Christian Kuhn uploaded patch set 35
V +112/06/22, 15:25 -
core-ci voted on patch set 35 V +1 12/06/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34724
-
Christian Kuhn uploaded patch set 36
V +112/06/22, 16:00 -
Christian Kuhn uploaded patch set 37 12/06/22, 16:08
-
core-ci voted on patch set 36 V +1 12/06/22, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34726
-
Christian Kuhn uploaded patch set 38 12/06/22, 16:13
-
core-ci voted on patch set 37 V +1 12/06/22, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34727
-
Christian Kuhn uploaded patch set 39 12/06/22, 16:16
-
core-ci voted on patch set 38 V +1 12/06/22, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34728
-
core-ci voted on patch set 39 V +1 12/06/22, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34729
-
Christian Kuhn uploaded patch set 40
V +112/06/22, 17:49 -
core-ci voted on patch set 40 V -1 12/06/22, 17:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34730
-
Christian Kuhn uploaded patch set 41
V -112/06/22, 17:58 -
Christian Kuhn commented on patch set 40 12/06/22, 17:58
this patch drives me nuts ... hope to finish it soon. -
core-ci voted on patch set 41 V +1 12/06/22, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34731
-
Christian Kuhn uploaded patch set 42
V +112/07/22, 15:11 -
core-ci voted on patch set 42 V +1 12/07/22, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34764
-
Christian Kuhn uploaded patch set 43
V +112/07/22, 16:52 -
Christian Kuhn uploaded patch set 44 12/07/22, 16:57
-
core-ci voted on patch set 43 V +1 12/07/22, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34768
-
core-ci voted on patch set 44 V +1 12/07/22, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34769
-
Christian Kuhn rebased onto patch set 45
V +112/07/22, 17:24 -
core-ci voted on patch set 45 V +1 12/07/22, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34771
-
Anja Leichsenring commented on patch set 45 V +1 CR +1 12/07/22, 19:21
played around with my testing instance for quite a while, no issue turned up. I think this is good to go. Thank you for all the effort, this makes the TYPO3 world a little bit better again. -
Stefan Bürk voted on patch set 45 V +1 CR +1 12/08/22, 10:01
-
Benni Mack commented on patch set 45 CR -2 12/08/22, 10:32
reviewing... -
Benni Mack voted on patch set 45 CR +1 12/08/22, 11:57
-
Christian Kuhn voted on patch set 45 V +2 CR +2 12/08/22, 12:03
-
Christian Kuhn merged patch set 46 12/08/22, 12:03
TypoScriptStringFactory.php:24