76567[TASK] Replace prophecy in EXT:core/Tests/Unit/Mail/*
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 4
- Task #98809Replace prophecy in EXT:core/Tests/Unit/Mail/MailerTest.php
- Task #98810Replace prophecy in EXT:core/Tests/Unit/Mail/Event/BeforeMailerSentMessageEventTest.php
- Task #98811Replace prophecy in EXT:core/Tests/Unit/Mail/Event/AfterMailerSentMessageEventTest.php
- Task #98812Replace prophecy in EXT:core/Tests/Unit/Mail/TransportFactoryTest.php
Files 4
Review log 79
-
Torben Hansen uploaded patch set 1 11/12/22, 11:24
-
core-ci voted on patch set 1 V +1 11/12/22, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33625
-
Oliver Klee commented on patch set 1 11/12/22, 12:27
TransportFactoryTest.php:48Could we use the NullLogger here? -
Torben Hansen uploaded patch set 2 11/12/22, 13:02
-
Torben Hansen commented on patch set 2 11/12/22, 13:02
MailerTest.php:72ReplyDoneTransportFactoryTest.php:48ReplyNo, I don`t think so, since we are mocking the LogManager here instead of the Logger. The NullLogger is however used one line below. -
core-ci voted on patch set 2 V +1 11/12/22, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33631
-
Christian Kuhn voted on patch set 2 V +1 CR +1 11/12/22, 13:44
-
Andreas Kienast voted on patch set 2 V +2 CR +2 11/12/22, 13:51
-
Andreas Kienast merged patch set 3 11/12/22, 13:51
MailerTest.php:72