Review main Merged

76567[TASK] Replace prophecy in EXT:core/Tests/Unit/Mail/*

Torben Hansen CR +2 V +2 Normal +28 −50 updated 11/12/22, 13:51

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 4

Files 4

Review log 79

  1. Torben Hansen uploaded patch set 1 11/12/22, 11:24

  2. core-ci voted on patch set 1 V +1 11/12/22, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33625

  3. Oliver Klee commented on patch set 1 11/12/22, 12:27

    MailerTest.php:72

    The willReturn is missing.

    TransportFactoryTest.php:48

    Could we use the NullLogger here?
  4. Torben Hansen uploaded patch set 2 11/12/22, 13:02

  5. Torben Hansen commented on patch set 2 11/12/22, 13:02

    MailerTest.php:72 Reply

    Done

    TransportFactoryTest.php:48 Reply

    No, I don`t think so, since we are mocking the LogManager here instead of the Logger. The NullLogger is however used one line below.
  6. core-ci voted on patch set 2 V +1 11/12/22, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33631

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 11/12/22, 13:44

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 11/12/22, 13:51

  9. Andreas Kienast merged patch set 3 11/12/22, 13:51