76571[TASK] Streamline TYPO3\CMS\Core\Utility\ArrayUtility::filterRecursive
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Georg Ringer +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1519
-
Oliver Hader uploaded patch set 1 11/12/22, 16:04
-
core-ci voted on patch set 1 V -1 11/12/22, 16:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33638
-
Oliver Hader uploaded patch set 2 11/12/22, 16:35
-
core-ci voted on patch set 2 V -1 11/12/22, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33643
-
Oliver Hader uploaded patch set 3 11/12/22, 16:53
-
Oliver Hader commented on patch set 3 11/12/22, 16:55
-
core-ci voted on patch set 3 V +1 11/12/22, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33645
-
Stefan Bürk voted on patch set 3 CR +1 11/12/22, 17:49
-
Nikita Hovratov commented on patch set 3 11/12/22, 18:21
ArrayUtility.php:941We could change this annotation for phpstan checks to: @param 0|ARRAY_FILTER_USE_KEY|ARRAY_FILTER_USE_BOTH $mode This would require to add it in ArrayUtilityTest as well, though. -
Stefan Bürk uploaded patch set 4 11/13/22, 00:48
-
Stefan Bürk commented on patch set 4 11/13/22, 00:48
ArrayUtility.php:941ReplyDone -
Stefan Bürk commented on patch set 4 11/13/22, 00:50
Also this change may be "safe", it is a signature change of a public method. Would say it's not really breaking ... so not sure about the backport here. Should we really do it ? -
core-ci voted on patch set 4 V +1 11/13/22, 00:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33658
-
Christian Kuhn commented on patch set 4 11/14/22, 07:32
Reply
adding an additional argument is safe to backport. -
Georg Ringer voted on patch set 4 V +1 CR +1 11/14/22, 09:13
-
Oliver Klee commented on patch set 4 11/14/22, 09:25
ArrayUtility.php:945ReplyAck -
Nikita Hovratov voted on patch set 4 V +1 CR +1 11/14/22, 09:40
-
Stefan Bürk voted on patch set 4 V +2 CR +2 11/15/22, 19:24
-
Stefan Bürk merged patch set 5 11/15/22, 19:24
ArrayUtility.php:945