Review main Merged

76575[TASK] Replace prophecy in EXT:core PageTsConfigParserTest

Nikita Hovratov CR +2 V +2 Normal +32 −34 updated 11/13/22, 09:31

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Nikita Hovratov uploaded patch set 1 11/12/22, 17:43

  2. core-ci voted on patch set 1 V -1 11/12/22, 18:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33648

  3. Nikita Hovratov uploaded patch set 2 11/12/22, 18:26

  4. core-ci voted on patch set 2 V +1 11/12/22, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33651

  5. Oliver Klee voted on patch set 2 V +1 11/12/22, 19:06

  6. Oliver Klee commented on patch set 2 CR -1 11/12/22, 19:31

    phpstan-baseline.neon:1439

    We should fix this.
  7. Oliver Klee voted on patch set 2 V 0 11/12/22, 20:02

  8. Nikita Hovratov uploaded patch set 3 11/12/22, 23:55

  9. Nikita Hovratov commented on patch set 3 11/12/22, 23:56

    phpstan-baseline.neon:1439 Reply

    Done
  10. core-ci voted on patch set 3 V +1 11/13/22, 00:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33656

  11. Stefan Bürk voted on patch set 3 V +1 CR +1 11/13/22, 00:32

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 11/13/22, 09:31

  13. Christian Kuhn merged patch set 4 11/13/22, 09:31