76577[TASK] Ensure proper site configuration cleanup in tests
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 32
- typo3/sysext/backend/Tests/Functional/Clipboard/ClipboardTest.php+1 −0
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+1 −0
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+6 −0
- typo3/sysext/backend/Tests/Functional/Utility/BackendUtilityTest.php+6 −0
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+1 −0
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php4+34 −10
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeBuilderTest.php+6 −0
- typo3/sysext/core/Tests/Functional/Utility/RootlineUtilityTest.php+6 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php+1 −0
- typo3/sysext/fluid/Tests/Functional/View/TemplatesPathsTest.php+6 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Format/HtmlViewHelperTest.php+6 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/EmailViewHelperTest.php+6 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+6 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+6 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Transform/HtmlViewHelperTest.php+6 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/PageViewHelperTest.php+6 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/TypolinkViewHelperTest.php+5 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/CObjectViewHelperTest.php+1 −0
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/SecureHtmlRenderingTest.php+6 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/AbstractRequestHandlingTest.php+1 −0
Show 12 more files
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+6 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/FluidTemplateContentObjectTest.php+6 −0
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php+6 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/BackendUserAuthenticatorTest.php+6 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/AbsoluteUriPrefixRenderingTest.php+6 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php+6 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+6 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+6 −0
- typo3/sysext/install/Tests/Functional/Updates/RowUpdater/SysRedirectRootPageMoveMigrationTest.php+1 −2
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+1 −0
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+6 −0
- typo3/sysext/seo/Tests/Functional/HrefLang/HrefLangGeneratorTest.php+6 −0
Review log 1216
-
Stefan Bürk uploaded patch set 1 11/12/22, 19:02
-
core-ci voted on patch set 1 V +1 11/12/22, 19:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33653
-
Stefan Bürk voted on patch set 1 CR -1 11/12/22, 19:29
-
Oliver Klee commented on patch set 1 11/12/22, 20:11
-
Oliver Klee commented on patch set 1 11/12/22, 21:20
SiteBasedTestTrait.php:321ReplyAh, this look like it’s about PHPStan complaining about the property not being defined. For this cases, we can add this annotation to the trait to let PHPStan (and human readers) know that this trait is expected to be used in functional tests only: /** * @mixin FunctionalTestCase */ -
Stefan Bürk commented on patch set 1 11/12/22, 21:28
SiteBasedTestTrait.php:321ReplyI have other issues with this patch still. And there's more why this patch is gonna happen. I have already done some things locally, but still working on it. That check was not about anything, it was because of trait and be save .. other code does not check it all, so the if here will vanish with the next push. So please wait for the next push and use your time for other changes first. -
Oliver Klee commented on patch set 1 11/12/22, 21:34
SiteBasedTestTrait.php:321ReplyAck -
Stefan Bürk uploaded patch set 2 11/12/22, 22:18
-
Stefan Bürk uploaded patch set 3 11/12/22, 22:24
-
core-ci voted on patch set 2 V +1 11/12/22, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33654
-
core-ci voted on patch set 3 V +1 11/12/22, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33655
-
Oliver Klee voted on patch set 3 V +1 11/12/22, 23:09
-
Oliver Klee commented on patch set 4 11/13/22, 11:46
Published edit on patch set 3. -
Oliver Klee voted on patch set 4 V +1 11/13/22, 11:46
-
core-ci voted on patch set 4 V +1 11/13/22, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33671
-
Stefan Bürk abandoned the change 11/13/22, 13:04
Abandon due generic cleanup in testing-framework with https://github.com/TYPO3/testing-framework/commit/e3213a9b6ad4ec7e3acae6f77a75a33f689eee08
SiteBasedTestTrait.php:321