Review main Merged

76578[TASK] Deprecate fe_users & fe_groups TSconfig

Christian Kuhn CR +2 V +2 Normal +109 −54 updated 11/14/22, 08:39

Commit message

TSconfig plays an important role in the Backend:
It configures rendering and behavior details in
the Backend and can be set on pages, be_users and
be_groups field, leading to UserTsConfig and
PageTsConfig.

Frontend users and Frontend groups have this
as well on database level, together with an
API in class FrontendUserAuthentication. This
was probably added in the old days to allow a
similar thing as Backend TSconfig for Frontend
users as well. It is however unused by the core
and there seems to be only a very limited number
of extensions that ever used this. Developers
think of "TSconfig" as Backend specific things,
and that's how it should be.

To reduce confusion, the patch deprecates the
TSconfig database fields in fe_groups and fe_users
table along with the PHP API.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 18

Review log 68

  1. Christian Kuhn uploaded patch set 1 11/13/22, 10:48

  2. core-ci voted on patch set 1 V +1 11/13/22, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33668

  3. Christian Kuhn uploaded patch set 2 11/13/22, 11:47

  4. core-ci voted on patch set 2 V +1 11/13/22, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33672

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 11/13/22, 12:38

  6. Benni Mack voted on patch set 2 V +1 CR +1 11/14/22, 08:34

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 11/14/22, 08:39

  8. Christian Kuhn merged patch set 3 11/14/22, 08:39