Review main Merged

76579[TASK] Replace prophecy in EXT:core/*/Unit/DataHandling/SoftReference/*

Torben Hansen CR +2 V +2 Normal +34 −39 updated 11/13/22, 14:14

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Torben Hansen uploaded patch set 1 11/13/22, 11:39

  2. core-ci voted on patch set 1 V +1 11/13/22, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33669

  3. Oliver Klee commented on patch set 1 11/13/22, 11:50

    TypoLinkSoftReferenceParserTest.php:246

    The with() is missing. As we're covering two calls here, we need to use something like willReturnMap.
  4. Oliver Klee voted on patch set 1 V +1 CR -1 11/13/22, 11:50

  5. Torben Hansen uploaded patch set 2 11/13/22, 13:07

  6. Oliver Klee commented on patch set 2 CR +1 11/13/22, 13:08

    TypoLinkSoftReferenceParserTest.php:246 Reply

    Done
  7. Torben Hansen commented on patch set 2 11/13/22, 13:09

    TypoLinkSoftReferenceParserTest.php:246 Reply

    Thanks a lot for the "willReturnMap" hint. I actually tried over an hour to get the test to work with "withConsecutive".
  8. core-ci voted on patch set 2 V +1 11/13/22, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33674

  9. Oliver Klee voted on patch set 2 V +1 11/13/22, 13:29

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 11/13/22, 14:14

  11. Christian Kuhn merged patch set 3 11/13/22, 14:14