Review main Merged

76582[BUGFIX] Use correct php namespace for NoopEventDispatcher

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 11/13/22, 18:49

Commit message

NoopEventDispatcher was originally a text fixture class
to help during testing. This class has been made available
to extension developers with #99070.

However, #98808 has been mergend without prior rebasing and
having wrong namespace for this class in a test class.

This change now uses the correct namespace to ensure tests
are working again.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 11/13/22, 18:40

  2. Oliver Klee voted on patch set 1 CR +1 11/13/22, 18:48

  3. core-ci voted on patch set 1 V +1 11/13/22, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33677

  4. Stefan Bürk commented on patch set 1 V +2 CR +2 11/13/22, 18:49

    Merging as no-brainer and un-blocker for contribution work.
  5. Stefan Bürk merged patch set 2 11/13/22, 18:49