Review main Merged

76593[TASK] Avoid additional nesting complexity in typo3-backend-column-selector-button

Benjamin Kott CR +2 V +2 Easy +27 −11 updated 11/14/22, 15:15

Commit message

The custom element typo3-backend-column-selector-button is a
valid HTML and should be used as such. There is no need to nest
buttons/links inside the element to add CSS styling.

We are adding keyboard events to react on the "Enter" and "Space"
keys to mimic the behavior of a button and setting defaults for the
role and tabindex to make it keyboard accessible. CSS classes are
now directly set to the element itself.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Benjamin Kott uploaded patch set 1 11/14/22, 11:01

  2. core-ci voted on patch set 1 V +1 11/14/22, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33696

  3. Andreas Kienast commented on patch set 1 V -1 11/14/22, 14:18

    Unfortunately, I cannot tab into the element anymore, so I cannot test the keyboard shortcuts.
  4. Andreas Kienast commented on patch set 1 V +1 CR +1 11/14/22, 14:20

    Never mind, it seemed to be a browser hickup.
  5. Benni Mack voted on patch set 1 V +2 CR +2 11/14/22, 15:15

  6. Benni Mack merged patch set 2 11/14/22, 15:15