76594[TASK] Introduce luxon and remove moment.js
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 19
- Build/Sources/TypeScript/backend/date-time-picker.ts2+15 −11
- Build/Sources/TypeScript/backend/drag-uploader.ts+7 −16
- Build/Sources/TypeScript/backend/form-engine-validation.ts+18 −13
- Build/types/TYPO3/index.d.ts+0 −1
- Build/Gruntfile.js+2 −2
- Build/package-lock.json+16 −21
- Build/package.json+2 −2
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+1 −1
- typo3/sysext/backend/Resources/Private/Partials/About/ExternalLibraries.html+4 −0
- typo3/sysext/backend/Resources/Public/JavaScript/date-time-picker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/core/Configuration/JavaScriptModules.php+1 −2
- typo3/sysext/core/Documentation/Changelog/12.1/Important-88158-ReplacedMomentJsWithLuxon.rstnew+22 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/luxon.jsnew+1 −0
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/moment-timezone.jsdeleted+0 −5
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/moment.jsdeleted+0 −6
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+2 −5
Review log 2636
Show 611 earlier messages
-
Andreas Kienast uploaded patch set 1 11/14/22, 11:33
-
core-ci voted on patch set 1 V -1 11/14/22, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33698
-
Andreas Kienast uploaded patch set 2 11/14/22, 12:21
-
core-ci voted on patch set 2 V -1 11/14/22, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33699
-
Andreas Kienast uploaded patch set 3 11/14/22, 12:37
-
core-ci voted on patch set 3 V +1 11/14/22, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33700
-
Andreas Kienast uploaded patch set 4 11/14/22, 14:09
-
core-ci voted on patch set 4 V -1 11/14/22, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33712
-
Andreas Kienast uploaded patch set 5 11/14/22, 14:21
-
core-ci voted on patch set 5 V +1 11/14/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33713
-
Georg Ringer commented on patch set 5 11/14/22, 14:56
-
Andreas Kienast commented on patch set 5 11/14/22, 15:05
date-time-picker.ts:127ReplyAck -
Andreas Kienast uploaded patch set 6 11/14/22, 15:06
-
Benni Mack commented on patch set 6 11/14/22, 15:15
moment.js was not part of the public API tbh, it was introduced in 2014: https://review.typo3.org/c/Packages/TYPO3.CMS/+/34094/ I don't think we need to either deprecate this or consider this in EXT:dashboard as relevant API tbh. I think it's good that we keep moment.js around, however since it is not maintained anymore, this is a real big problem with security issues in dependencies, so I'm fine with having only 1 Important.rst (not a feature, not a deprecation), also removing it in EXT:dashboard. -
core-ci voted on patch set 6 V +1 11/14/22, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33716
-
Andreas Kienast uploaded patch set 7 11/14/22, 15:28
-
Andreas Kienast updated the commit message in patch set 8 11/14/22, 15:31
-
Andreas Kienast commented on patch set 8 11/14/22, 15:32
Reply
Tough one. EXT:dashboard uses chart.js which requires moment. We have to update chart.js to version 3 to get rid of this dependency, which is breaking existing code. AFAICS there is no live migration for existing configuration available. -
core-ci voted on patch set 7 V +1 11/14/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33718
-
core-ci voted on patch set 8 V +1 11/14/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33719
-
Benni Mack voted on patch set 8 CR +1 11/14/22, 17:05
-
Andreas Kienast uploaded patch set 9 11/16/22, 06:23
-
core-ci voted on patch set 9 V +1 11/16/22, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33802
-
Benni Mack voted on patch set 9 V +1 CR +1 11/16/22, 07:20
-
Frank Nägler commented on patch set 9 11/16/22, 11:28
Because luxon and moment.js have some difference in the date format syntax, this change is possible breaking, right? e.g. `dd` vs `DD` IIRC we should mark the patch as breaking and add an rst file with some information how to migrate the formats. -
Frank Nägler commented on patch set 9 11/16/22, 11:34
ignore my last comment, I mixed php date format settings and TCA format option. -
Christian Kuhn commented on patch set 9 11/17/22, 19:23
note: v12 before and after patch looks funny: "today" is a blue, and "current selection" as well. this is different in v11 where "today" just has a border. -
Stefan Bürk voted on patch set 9 V +1 CR +1 11/18/22, 14:56
-
Andreas Kienast commented on patch set 9 CR -2 11/21/22, 10:31
Waiting for https://review.typo3.org/c/Packages/TYPO3.CMS/+/76692, which makes moment.js finally obsolete. -
Andreas Kienast uploaded patch set 10
CR +1V +111/22/22, 11:52Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Andreas Kienast voted on patch set 10 CR 0 11/22/22, 11:52
-
core-ci voted on patch set 10 V +1 11/22/22, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34071
-
Frank Nägler voted on patch set 10 V +1 CR +1 11/22/22, 13:17
-
Georg Ringer voted on patch set 10 V +1 CR +1 11/22/22, 13:24
-
Andreas Kienast voted on patch set 10 V +2 CR +2 11/22/22, 14:10
-
Andreas Kienast merged patch set 11 11/22/22, 14:10
date-time-picker.ts:127