Review main Merged

76594[TASK] Introduce luxon and remove moment.js

Andreas Kienast CR +2 V +2 Normal +95 −89 updated 11/22/22, 14:10

Commit message

The JavaScript library `luxon` is added to TYPO3 as a replacement for
`moment.js` that is considered legacy software by the original
maintainers.

As a convenience change, the dates rendered in the "conflict modal" in
the file upload process are now properly human-readable (e.g.
"Apr 3, 2022, 12:56 PM"). The property `lastModifiedDate` is not part of
the official browser APIs anymore, therefore it's not considered
anymore.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 2636

Show 611 earlier messages
  1. Andreas Kienast uploaded patch set 1 11/14/22, 11:33

  2. core-ci voted on patch set 1 V -1 11/14/22, 11:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33698

  3. Andreas Kienast uploaded patch set 2 11/14/22, 12:21

  4. core-ci voted on patch set 2 V -1 11/14/22, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33699

  5. Andreas Kienast uploaded patch set 3 11/14/22, 12:37

  6. core-ci voted on patch set 3 V +1 11/14/22, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33700

  7. Andreas Kienast uploaded patch set 4 11/14/22, 14:09

  8. core-ci voted on patch set 4 V -1 11/14/22, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33712

  9. Andreas Kienast uploaded patch set 5 11/14/22, 14:21

  10. core-ci voted on patch set 5 V +1 11/14/22, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33713

  11. Georg Ringer commented on patch set 5 11/14/22, 14:56

    date-time-picker.ts:127

    i guess this should be removed
  1. Andreas Kienast commented on patch set 5 11/14/22, 15:05

    date-time-picker.ts:127 Reply

    Ack
  2. Andreas Kienast uploaded patch set 6 11/14/22, 15:06

  3. Benni Mack commented on patch set 6 11/14/22, 15:15

    moment.js was not part of the public API tbh, it was introduced in 2014: https://review.typo3.org/c/Packages/TYPO3.CMS/+/34094/ I don't think we need to either deprecate this or consider this in EXT:dashboard as relevant API tbh. I think it's good that we keep moment.js around, however since it is not maintained anymore, this is a real big problem with security issues in dependencies, so I'm fine with having only 1 Important.rst (not a feature, not a deprecation), also removing it in EXT:dashboard.
  4. core-ci voted on patch set 6 V +1 11/14/22, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33716

  5. Andreas Kienast uploaded patch set 7 11/14/22, 15:28

  6. Andreas Kienast updated the commit message in patch set 8 11/14/22, 15:31

  7. Andreas Kienast commented on patch set 8 11/14/22, 15:32

    Reply

    Tough one. EXT:dashboard uses chart.js which requires moment. We have to update chart.js to version 3 to get rid of this dependency, which is breaking existing code. AFAICS there is no live migration for existing configuration available.
  8. core-ci voted on patch set 7 V +1 11/14/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33718

  9. core-ci voted on patch set 8 V +1 11/14/22, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33719

  10. Benni Mack voted on patch set 8 CR +1 11/14/22, 17:05

  11. Andreas Kienast uploaded patch set 9 11/16/22, 06:23

  12. core-ci voted on patch set 9 V +1 11/16/22, 06:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33802

  13. Benni Mack voted on patch set 9 V +1 CR +1 11/16/22, 07:20

  14. Frank Nägler commented on patch set 9 11/16/22, 11:28

    Because luxon and moment.js have some difference in the date format syntax, this change is possible breaking, right? e.g. `dd` vs `DD` IIRC we should mark the patch as breaking and add an rst file with some information how to migrate the formats.
  15. Frank Nägler commented on patch set 9 11/16/22, 11:34

    ignore my last comment, I mixed php date format settings and TCA format option.
  16. Christian Kuhn commented on patch set 9 11/17/22, 19:23

    note: v12 before and after patch looks funny: "today" is a blue, and "current selection" as well. this is different in v11 where "today" just has a border.
  17. Stefan Bürk voted on patch set 9 V +1 CR +1 11/18/22, 14:56

  18. Andreas Kienast commented on patch set 9 CR -2 11/21/22, 10:31

    Waiting for https://review.typo3.org/c/Packages/TYPO3.CMS/+/76692, which makes moment.js finally obsolete.
  19. Andreas Kienast uploaded patch set 10 CR +1 V +1 11/22/22, 11:52

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  20. Andreas Kienast voted on patch set 10 CR 0 11/22/22, 11:52

  21. core-ci voted on patch set 10 V +1 11/22/22, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34071

  22. Frank Nägler voted on patch set 10 V +1 CR +1 11/22/22, 13:17

  23. Georg Ringer voted on patch set 10 V +1 CR +1 11/22/22, 13:24

  24. Andreas Kienast voted on patch set 10 V +2 CR +2 11/22/22, 14:10

  25. Andreas Kienast merged patch set 11 11/22/22, 14:10