Review main Merged

76602[FEATURE] Introduce DropDownButton component

Benjamin Kott CR +2 V +2 Hard +886 −103 updated 11/16/22, 08:08

Commit message

The module menu button bar now can display dropdowns.
This enables new interface interactions, like switching
the current view from list to tiles or group actions
like clipboard and thumbnail visibility. It will help
declutter views and help the user to see more information
at a glance.

Each dropdown consists of different items ranging from
headlines to items links that can display the current
status. The button will automaticly change the icon
representation to the icon of the the first active radio
icon in the dropdown.

It is now implemented in the File List module to switch
between Thumbnails and enable Actions like Clipboard

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1

Issues 1

Files 19

Review log 2134

Show 59 earlier messages
  1. Benjamin Kott uploaded patch set 1 11/15/22, 08:08

  2. core-ci voted on patch set 1 V -1 11/15/22, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33736

  3. Benjamin Kott uploaded patch set 2 11/15/22, 08:21

  4. core-ci voted on patch set 2 V -1 11/15/22, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33737

  5. Benjamin Kott uploaded patch set 3 11/15/22, 09:21

  6. core-ci voted on patch set 3 V -1 11/15/22, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33742

  7. Benni Mack commented on patch set 3 11/15/22, 09:47

    FileListController.php:55

    class is missing in this patch set
  8. Benjamin Kott uploaded patch set 4 11/15/22, 12:05

  9. core-ci voted on patch set 4 V -1 11/15/22, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33748

  1. Benjamin Kott uploaded patch set 5 11/15/22, 12:43

  2. Benjamin Kott uploaded patch set 6 11/15/22, 12:55

  3. core-ci voted on patch set 5 V -1 11/15/22, 12:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33750

  4. core-ci voted on patch set 6 V -1 11/15/22, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33754

  5. Andreas Kienast commented on patch set 6 CR -1 11/15/22, 13:16

    AbstractDropDownItem.php:119

    `$this->getIcon()?->render() ?? '';` should do the same.

    DropDownItem.php:19

    Did you find it?

    DropDownRadio.php:26

    Personally I'd prefer the name "isActive()"

    DropDownToggle.php:38

    Personally I'd prefer the name "isActive()"

    DropDownButton.php:66

    Would it make more sense to render '' if there are no items instead?
  6. Benjamin Kott uploaded patch set 7 11/15/22, 13:38

  7. Benjamin Kott uploaded patch set 8 11/15/22, 13:42

  8. Benjamin Kott commented on patch set 7 11/15/22, 13:42

    AbstractDropDownItem.php:119 Reply

    Done

    AbstractDropDownItem.php:119 Reply

    Done

    DropDownItem.php:19 Reply

    Done

    DropDownRadio.php:26 Reply

    Done

    DropDownToggle.php:38 Reply

    Done

    FileListController.php:55 Reply

    Done
  9. Benjamin Kott commented on patch set 8 11/15/22, 13:47

    DropDownButton.php:66 Reply

    not sure about this, general behavior is that if an element is not valid it throws an exception
  10. core-ci voted on patch set 7 V -1 11/15/22, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33756

  11. core-ci voted on patch set 8 V -1 11/15/22, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33757

  12. Benjamin Kott uploaded patch set 9 11/15/22, 14:10

  13. core-ci voted on patch set 9 V -1 11/15/22, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33760

  14. Benjamin Kott uploaded patch set 10 11/15/22, 15:25

  15. core-ci voted on patch set 10 V +1 11/15/22, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33765

  16. Benjamin Kott uploaded patch set 11 11/16/22, 05:44

  17. core-ci voted on patch set 11 V +1 11/16/22, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33801

  18. Benjamin Kott uploaded patch set 12 11/16/22, 07:54

  19. Benni Mack uploaded patch set 13 11/16/22, 08:00

  20. Benni Mack voted on patch set 13 V +1 CR +1 11/16/22, 08:00

  21. core-ci voted on patch set 12 V +1 11/16/22, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33806

  22. Andreas Kienast voted on patch set 13 V +2 CR +2 11/16/22, 08:05

  23. Benni Mack merged patch set 14 11/16/22, 08:08

  24. Benni Mack commented on patch set 14 11/16/22, 08:08

    DropDownButton.php:66 Reply

    Done
  25. core-ci voted on patch set 13 V +1 11/16/22, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33807