76602[FEATURE] Introduce DropDownButton component
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
Issues 1
Files 19
- Build/Sources/Sass/component/_dropdown.scss+1 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/AbstractDropDownItem.php3new+133 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownDivider.phpnew+42 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownHeader.phpnew+58 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownItem.php2new+55 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownItemInterface.phpnew+23 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownRadio.php2new+84 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDown/DropDownToggle.php2new+69 −0
- typo3/sysext/backend/Classes/Template/Components/Buttons/DropDownButton.php3new+181 −0
- typo3/sysext/backend/Classes/Template/Components/ButtonBar.php+11 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+21 −1
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+0 −11
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-99093-IntroduceDropDownButtonComponent.rstnew+149 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+12 −0
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+1 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php2+45 −43
- typo3/sysext/filelist/Resources/Private/Language/locallang_mod_file_list.xlf+0 −3
- typo3/sysext/filelist/Resources/Private/Templates/File/List.html+0 −43
Review log 2134
Show 59 earlier messages
-
Benjamin Kott uploaded patch set 1 11/15/22, 08:08
-
core-ci voted on patch set 1 V -1 11/15/22, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33736
-
Benjamin Kott uploaded patch set 2 11/15/22, 08:21
-
core-ci voted on patch set 2 V -1 11/15/22, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33737
-
Benjamin Kott uploaded patch set 3 11/15/22, 09:21
-
core-ci voted on patch set 3 V -1 11/15/22, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33742
-
Benni Mack commented on patch set 3 11/15/22, 09:47
-
Benjamin Kott uploaded patch set 4 11/15/22, 12:05
-
core-ci voted on patch set 4 V -1 11/15/22, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33748
-
Benjamin Kott uploaded patch set 5 11/15/22, 12:43
-
Benjamin Kott uploaded patch set 6 11/15/22, 12:55
-
core-ci voted on patch set 5 V -1 11/15/22, 12:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33750
-
core-ci voted on patch set 6 V -1 11/15/22, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33754
-
Andreas Kienast commented on patch set 6 CR -1 11/15/22, 13:16
AbstractDropDownItem.php:119`$this->getIcon()?->render() ?? '';` should do the same.DropDownItem.php:19Did you find it?DropDownRadio.php:26Personally I'd prefer the name "isActive()"DropDownToggle.php:38Personally I'd prefer the name "isActive()"DropDownButton.php:66Would it make more sense to render '' if there are no items instead? -
Benjamin Kott uploaded patch set 7 11/15/22, 13:38
-
Benjamin Kott uploaded patch set 8 11/15/22, 13:42
-
Benjamin Kott commented on patch set 7 11/15/22, 13:42
AbstractDropDownItem.php:119ReplyDoneAbstractDropDownItem.php:119ReplyDoneDropDownItem.php:19ReplyDoneDropDownRadio.php:26ReplyDoneDropDownToggle.php:38ReplyDoneFileListController.php:55ReplyDone -
Benjamin Kott commented on patch set 8 11/15/22, 13:47
DropDownButton.php:66Replynot sure about this, general behavior is that if an element is not valid it throws an exception -
core-ci voted on patch set 7 V -1 11/15/22, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33756
-
core-ci voted on patch set 8 V -1 11/15/22, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33757
-
Benjamin Kott uploaded patch set 9 11/15/22, 14:10
-
core-ci voted on patch set 9 V -1 11/15/22, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33760
-
Benjamin Kott uploaded patch set 10 11/15/22, 15:25
-
core-ci voted on patch set 10 V +1 11/15/22, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33765
-
Benjamin Kott uploaded patch set 11 11/16/22, 05:44
-
core-ci voted on patch set 11 V +1 11/16/22, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33801
-
Benjamin Kott uploaded patch set 12 11/16/22, 07:54
-
Benni Mack uploaded patch set 13 11/16/22, 08:00
-
Benni Mack voted on patch set 13 V +1 CR +1 11/16/22, 08:00
-
core-ci voted on patch set 12 V +1 11/16/22, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33806
-
Andreas Kienast voted on patch set 13 V +2 CR +2 11/16/22, 08:05
-
Benni Mack merged patch set 14 11/16/22, 08:08
-
Benni Mack commented on patch set 14 11/16/22, 08:08
DropDownButton.php:66ReplyDone -
core-ci voted on patch set 13 V +1 11/16/22, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33807
FileListController.php:55