76607[TASK] Drop backend.js
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/adminpanel/Resources/Private/Templates/Main.html+1 −1
- typo3/sysext/backend/Classes/Controller/BackendController.php+4 −0
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+0 −3
- typo3/sysext/backend/Resources/Public/JavaScript/backend.js5deleted+0 −25
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsGroupCest.php+6 −6
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+6 −6
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineContentElementLocalizeSynchronizeCest.php+8 −8
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlinePagesLocalizeResourceCest.php+3 −3
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+0 −1
Review log 1723
-
Andreas Kienast uploaded patch set 1 11/15/22, 13:55
-
core-ci voted on patch set 1 V -1 11/15/22, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33759
-
Andreas Kienast uploaded patch set 2 11/15/22, 15:48
-
Andreas Kienast uploaded patch set 3 11/15/22, 15:51
-
Andreas Kienast uploaded patch set 4 11/15/22, 15:51
-
core-ci voted on patch set 4 V -1 11/15/22, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33769
-
Andreas Kienast uploaded patch set 5 11/15/22, 16:31
-
Andreas Kienast uploaded patch set 6 11/15/22, 16:44
-
core-ci voted on patch set 5 V -1 11/15/22, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33773
-
core-ci voted on patch set 6 V +1 11/15/22, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33775
-
Andreas Kienast uploaded patch set 7 11/16/22, 06:32
-
Andreas Kienast updated the commit message in patch set 8 11/16/22, 06:34
-
core-ci voted on patch set 7 V +1 11/16/22, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33803
-
core-ci voted on patch set 8 V +1 11/16/22, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33804
-
Christian Kuhn voted on patch set 8 V +1 CR +1 11/16/22, 11:02
-
Frank Nägler commented on patch set 8 11/16/22, 11:39
-
Andreas Kienast commented on patch set 8 11/16/22, 11:43
backend.js:15ReplyI am, that‘s why I hardcoded the name of the window to „typo3-backend“. -
Frank Nägler commented on patch set 8 11/16/22, 12:02
backend.js:15ReplyOk, thx, I have not tested it yet, will do it later. -
Benni Mack commented on patch set 8 11/16/22, 12:07
backend.js:15ReplyWhat happens if you have two TYPO3 backends opened in 2 tabs? -
Andreas Kienast commented on patch set 8 11/16/22, 12:19
backend.js:15ReplyInteresting case. I just tested this in Chrome and when I click the "Open page in backend" button in EXT:adminpanel, the newer of the backend tabs is focussed and updated. -
Frank Nägler commented on patch set 8 V +1 CR +1 11/16/22, 12:41
looks good, also with multi tabs. the last opened tab get the focus. -
Andreas Kienast voted on patch set 8 V +2 CR +2 11/16/22, 12:52
-
Andreas Kienast merged patch set 9 11/16/22, 12:52
backend.js:15