Review main Merged

76607[TASK] Drop backend.js

Andreas Kienast CR +2 V +2 Normal +28 −53 updated 11/16/22, 12:52

Commit message

The file backend.js contained some basic preparations for the backend
context that are partially not required anymore. The remaining settings
are converted to a global assignment set in BackendController.

The `window.name` property is now hard-coded to be `typo3-backend` for
use with the EXT:adminpanel, which requires some changes in acceptance
tests as `window.name` had an empty value before.
`window.opener` is nulled, otherwise, this might cause issues with
inter-frame communication if the backend was e.g. opened via a link in
an email.

With the remaining assigned being migrated, backend.js serves no purpose
anymore and is dropped now.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1723

  1. Andreas Kienast uploaded patch set 1 11/15/22, 13:55

  2. core-ci voted on patch set 1 V -1 11/15/22, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33759

  3. Andreas Kienast uploaded patch set 2 11/15/22, 15:48

  4. Andreas Kienast uploaded patch set 3 11/15/22, 15:51

  5. Andreas Kienast uploaded patch set 4 11/15/22, 15:51

  6. core-ci voted on patch set 4 V -1 11/15/22, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33769

  7. Andreas Kienast uploaded patch set 5 11/15/22, 16:31

  8. Andreas Kienast uploaded patch set 6 11/15/22, 16:44

  9. core-ci voted on patch set 5 V -1 11/15/22, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33773

  10. core-ci voted on patch set 6 V +1 11/15/22, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33775

  11. Andreas Kienast uploaded patch set 7 11/16/22, 06:32

  12. Andreas Kienast updated the commit message in patch set 8 11/16/22, 06:34

  13. core-ci voted on patch set 7 V +1 11/16/22, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33803

  14. core-ci voted on patch set 8 V +1 11/16/22, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33804

  15. Christian Kuhn voted on patch set 8 V +1 CR +1 11/16/22, 11:02

  16. Frank Nägler commented on patch set 8 11/16/22, 11:39

    backend.js:15

    Are you sure this is not required anymore? It was introduced some months ago for an admin panel feature.
  17. Andreas Kienast commented on patch set 8 11/16/22, 11:43

    backend.js:15 Reply

    I am, that‘s why I hardcoded the name of the window to „typo3-backend“.
  18. Frank Nägler commented on patch set 8 11/16/22, 12:02

    backend.js:15 Reply

    Ok, thx, I have not tested it yet, will do it later.
  19. Benni Mack commented on patch set 8 11/16/22, 12:07

    backend.js:15 Reply

    What happens if you have two TYPO3 backends opened in 2 tabs?
  20. Andreas Kienast commented on patch set 8 11/16/22, 12:19

    backend.js:15 Reply

    Interesting case. I just tested this in Chrome and when I click the "Open page in backend" button in EXT:adminpanel, the newer of the backend tabs is focussed and updated.
  21. Frank Nägler commented on patch set 8 V +1 CR +1 11/16/22, 12:41

    looks good, also with multi tabs. the last opened tab get the focus.
  22. Andreas Kienast voted on patch set 8 V +2 CR +2 11/16/22, 12:52

  23. Andreas Kienast merged patch set 9 11/16/22, 12:52