Review main Merged

76609[TASK] Make TcaSystemLanguageCollectorTest a functional

Christian Kuhn CR +2 V +2 Hard +111 −152 updated 11/15/22, 15:49

Commit message

Create a functional test form the rather heavily
mocking unit test, and streamline.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Christian Kuhn uploaded patch set 1 11/15/22, 15:22

  2. core-ci voted on patch set 1 V +1 11/15/22, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33763

  3. Benni Mack voted on patch set 1 CR +1 11/15/22, 15:34

  4. Benni Mack voted on patch set 1 V +1 11/15/22, 15:36

  5. Jochen Roth voted on patch set 1 V +1 CR +1 11/15/22, 15:37

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 11/15/22, 15:48

  7. Christian Kuhn merged patch set 2 11/15/22, 15:49