Review main Merged

7663[CLEANUP] Core has a XML syntax dependency on templavoila

Benni Mack CR +2 V +2 Easy +22 −19 updated 06/03/13, 20:49

Commit message

The TYPO3 core still uses "tx_templavoila" in a XML structure
for referencing the title for a structure like FlexForms with
sections etc. This means that code always looks / looked
like this:
<tx_templavoila>
<title>ABCDEF</title>
</tx_templavoila>

you can see this syntax in EXT:cms/flexform_media.xml.

The change in the Core is to support the new format
(without nesting in tx_templavoila) and deprecate but still
support the old format (see above).

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Georg Ringer +1
    • Xavier Perseguers +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Ritter +2
    • Philipp Gampe +1

Issues 1

Files 2

Review log 7

  1. Xavier Perseguers commented on patch set 1 01/04/12, 08:23

    Looks good to me, but someone else must approve
  2. Georg Ringer commented on patch set 1 01/04/12, 08:23

    Looks good to me, but someone else must approve
  3. Steffen Ritter commented on patch set 1 01/04/12, 08:23

    Verified; Looks good to me, but someone else must approve
  4. Steffen Ritter commented on patch set 1 V 0 01/04/12, 08:23

    by team member; Looks good to me, approved
  5. Philipp Gampe commented on patch set 1 01/04/12, 08:23

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 01/04/12, 08:23

  7. Steffen Ritter merged patch set 1 01/04/12, 08:23