76634[TASK] Replace instance cache in FormProtectionFactory
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 10
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php2+0 −7
- typo3/sysext/backend/Tests/Functional/Controller/MfaControllerTest.php+0 −7
- typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php+77 −111
- typo3/sysext/core/Classes/ServiceProvider.php+2 −0
- typo3/sysext/core/Documentation/Changelog/12.1/Deprecation-99098-StaticUsageOfFormProtectionFactory.rstnew+140 −0
- typo3/sysext/core/Tests/Functional/Authentication/Mfa/Provider/RecoveryCodesProviderTest.php+0 −7
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+5 −7
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php+11 −90
- typo3/sysext/core/Tests/UnitDeprecated/FormProtection/FormProtectionFactoryTest.phpnew+167 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+14 −0
Review log 1624
-
Stefan Bürk uploaded patch set 1 11/15/22, 18:42
-
Stefan Bürk uploaded patch set 2 11/15/22, 18:48
-
core-ci voted on patch set 1 V +1 11/15/22, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33776
-
core-ci voted on patch set 2 V +1 11/15/22, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33778
-
Benni Mack commented on patch set 2 11/15/22, 20:40
-
Stefan Bürk uploaded patch set 3 11/15/22, 20:44
-
Stefan Bürk commented on patch set 3 11/15/22, 20:44
MfaConfigurationControllerTest.php:73ReplyAck & done (+ another superflous tearDown) -
core-ci voted on patch set 3 V +1 11/15/22, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33784
-
Stefan Bürk uploaded patch set 4 11/15/22, 23:19
-
core-ci voted on patch set 4 V +1 11/15/22, 23:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33785
-
Stefan Bürk commented on patch set 4 11/16/22, 01:40
Running nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/33791 -
core-ci commented on patch set 4 11/16/22, 02:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33791
-
Benni Mack uploaded patch set 5 11/16/22, 08:07
-
core-ci voted on patch set 5 V +1 11/16/22, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33808
-
Benni Mack voted on patch set 5 V +1 CR +1 11/16/22, 08:19
-
Christian Kuhn commented on patch set 5 CR -1 11/16/22, 11:39
on it. -
Christian Kuhn uploaded patch set 6 11/16/22, 13:02
-
Christian Kuhn uploaded patch set 7 11/16/22, 13:03
-
core-ci voted on patch set 6 V +1 11/16/22, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33825
-
core-ci voted on patch set 7 V +1 11/16/22, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33826
-
Christian Kuhn voted on patch set 7 V +1 CR +1 11/16/22, 13:16
-
Benni Mack voted on patch set 7 V +1 CR +1 11/16/22, 13:17
-
Stefan Bürk voted on patch set 7 V +2 CR +2 11/16/22, 13:22
-
Stefan Bürk merged patch set 8 11/16/22, 13:22
MfaConfigurationControllerTest.php:73