Review main Merged

76641[TASK] Replace prophecy in EXT:core ExpressionBuilderTest

Torben Hansen CR +2 V +2 Hard +161 −171 updated 11/16/22, 11:11

Commit message

Note, that the argument usage in callback return functions had
to be adjusted. Also, mocking of the `quote` function for sqlite
tests had to be adapted to match the actual amount of consecutive
calls.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Torben Hansen uploaded patch set 1 11/16/22, 09:42

  2. core-ci voted on patch set 1 V +1 11/16/22, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33816

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 11/16/22, 11:05

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 11/16/22, 11:11

  5. Stefan Bürk merged patch set 2 11/16/22, 11:11