Review 11.5 Merged

76653[TASK] Annotate ActionController methods that never return

Oliver Klee CR +2 V +2 Easy +4 −5 updated 11/17/22, 09:22

Commit message

Extbase controllers that call a never-returning method do not
need a return statement after that call in order to avoid
calling the rest of the action method. The new annotations
ensure that PHPStan becomes aware of this control flow.

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 58

  1. Oliver Klee uploaded patch set 1 11/17/22, 08:07

  2. Oliver Klee uploaded patch set 2 11/17/22, 08:13

  3. Oliver Klee updated the commit message in patch set 3 11/17/22, 08:13

  4. core-ci voted on patch set 2 V +1 11/17/22, 08:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33846

  5. core-ci voted on patch set 1 V -1 11/17/22, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33844

  6. core-ci voted on patch set 3 V +1 11/17/22, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33847

  7. Christian Kuhn voted on patch set 3 V +2 CR +2 11/17/22, 09:22

  8. Christian Kuhn merged patch set 4 11/17/22, 09:22