Review main Merged

76654[TASK] Make the action name in ActionController::redirect() nullable

Oliver Klee CR +2 V +2 Easy +1 −1 updated 11/17/22, 18:04

Commit message

Passing no action name is a perfectly fine use case as this allows
to conveniently redirect from a controller action to any page.

Making this explicit in the type annotations allows extension authors
to use this pattern without type checkers like PHPStan creating a
warnings about this.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oliver Klee uploaded patch set 1 11/17/22, 08:21

  2. core-ci voted on patch set 1 V +1 11/17/22, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33849

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 11/17/22, 11:19

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 11/17/22, 18:04

  5. Anja Leichsenring merged patch set 2 11/17/22, 18:04