Review main Merged

76659[TASK] Avoid TypoScriptParser for string snippets

Christian Kuhn CR +2 V +2 Hard +370 −171 updated 11/17/22, 13:00

Commit message

There are a couple of places in the core care
that parse a TypoScript a-like syntax.
The patch switches them to the new TypoScript
parser by adding a factory class that is
able to parse single string snippets.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Kevin Appelt +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Kevin Appelt +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 16

Review log 1013

  1. Christian Kuhn uploaded patch set 1 11/17/22, 09:00

  2. Benni Mack commented on patch set 1 11/17/22, 09:10

    StringTreeBuilder.php:75

    can we use allowed_classes?
  3. core-ci voted on patch set 1 V -1 11/17/22, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33856

  4. Christian Kuhn commented on patch set 1 11/17/22, 09:20

    StringTreeBuilder.php:75 Reply

    ah, good point. but we're not doing that in other places of the TS parser, either. imho: keep for now and have a dedicated patch later?
  5. Christian Kuhn commented on patch set 1 CR -1 11/17/22, 09:58

    will add same functionals.

    StringTreeBuilder.php:75 Reply

    to be honest, i actually forgot about this detail in the main api ;) will take care as dedicated patch later.
  6. Christian Kuhn uploaded patch set 2 11/17/22, 10:35

  7. core-ci voted on patch set 2 V +1 11/17/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33865

  8. Christian Kuhn updated the commit message in patch set 3 11/17/22, 11:04

  9. core-ci voted on patch set 3 V +1 11/17/22, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33866

  10. Kevin Appelt voted on patch set 3 V +1 CR +1 11/17/22, 12:45

  11. Stefan Bürk voted on patch set 3 V +1 CR +1 11/17/22, 12:58

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 11/17/22, 12:59

  13. Christian Kuhn merged patch set 4 11/17/22, 13:00