76659[TASK] Avoid TypoScriptParser for string snippets
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Kevin Appelt +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Kevin Appelt +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 16
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+29 −30
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+27 −56
- typo3/sysext/backend/Configuration/Services.yaml+4 −0
- typo3/sysext/core/Classes/Configuration/ExtensionConfiguration.php+15 −70
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/StringInclude.phpnew+28 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/StringTreeBuilder.php3new+76 −0
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php+10 −7
- typo3/sysext/core/Classes/TypoScript/TypoScriptService.php+12 −5
- typo3/sysext/core/Classes/TypoScript/TypoScriptStringFactory.phpnew+76 −0
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/core/Classes/ServiceProvider.php+6 −0
- typo3/sysext/core/Configuration/Services.yaml+6 −0
- typo3/sysext/core/Tests/Functional/TypoScript/Fixtures/SimpleCondition.typoscriptnew+4 −0
- typo3/sysext/core/Tests/Functional/TypoScript/TypoScriptStringFactoryTest.phpnew+74 −0
- typo3/sysext/core/Tests/Unit/Fixtures/EventDispatcher/MockEventDispatcher.php+1 −1
- typo3/sysext/install/Classes/Controller/LayoutController.php+1 −1
Review log 1013
-
Christian Kuhn uploaded patch set 1 11/17/22, 09:00
-
Benni Mack commented on patch set 1 11/17/22, 09:10
-
core-ci voted on patch set 1 V -1 11/17/22, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33856
-
Christian Kuhn commented on patch set 1 11/17/22, 09:20
StringTreeBuilder.php:75Replyah, good point. but we're not doing that in other places of the TS parser, either. imho: keep for now and have a dedicated patch later? -
Christian Kuhn commented on patch set 1 CR -1 11/17/22, 09:58
will add same functionals.StringTreeBuilder.php:75Replyto be honest, i actually forgot about this detail in the main api ;) will take care as dedicated patch later. -
Christian Kuhn uploaded patch set 2 11/17/22, 10:35
-
core-ci voted on patch set 2 V +1 11/17/22, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33865
-
Christian Kuhn updated the commit message in patch set 3 11/17/22, 11:04
-
core-ci voted on patch set 3 V +1 11/17/22, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33866
-
Kevin Appelt voted on patch set 3 V +1 CR +1 11/17/22, 12:45
-
Stefan Bürk voted on patch set 3 V +1 CR +1 11/17/22, 12:58
-
Christian Kuhn voted on patch set 3 V +2 CR +2 11/17/22, 12:59
-
Christian Kuhn merged patch set 4 11/17/22, 13:00
StringTreeBuilder.php:75