Review main Merged

76666[TASK] Replace prophecy in EXT:core/Tests/Unit/Database/*

Torben Hansen CR +2 V +2 Expert +425 −658 updated 11/17/22, 21:31

Commit message

Note, that the combination of shouldBeCalled and shouldNotBeCalled
for the `quoteIdentifier` function in `QueryBuilderTest` has
been replaced with the `never` expectation only, since the tests
only test, if the star placeholder is not quoted.

Also 2 new mock classes have been introduced to cover the tests
in `AbstractRestrictionContainerTest`, where the mock object
must implement 2 interfaces, which is not mockable.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 13

Files 15

Review log 1013

  1. Torben Hansen uploaded patch set 1 11/17/22, 18:48

  2. Torben Hansen updated the commit message in patch set 2 11/17/22, 18:54

  3. core-ci voted on patch set 1 V +1 11/17/22, 18:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33887

  4. core-ci voted on patch set 2 V +1 11/17/22, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33888

  5. Oliver Klee voted on patch set 2 V +1 11/17/22, 19:07

  6. Christian Kuhn commented on patch set 2 11/17/22, 21:13

    QueryBuilderTest.php:43

    shorten namespace

    SetTypeTest.php:59

    rename variable?
  7. Christian Kuhn uploaded patch set 3 11/17/22, 21:19

  8. Christian Kuhn commented on patch set 2 11/17/22, 21:19

    QueryBuilderTest.php:43 Reply

    Done
  9. Christian Kuhn voted on patch set 3 V +1 CR +1 11/17/22, 21:23

  10. core-ci voted on patch set 3 V +1 11/17/22, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33890

  11. Stefan Bürk voted on patch set 3 CR +2 11/17/22, 21:30

  12. Stefan Bürk voted on patch set 3 V +2 11/17/22, 21:31

  13. Stefan Bürk merged patch set 4 11/17/22, 21:31