Review main Merged

76694[TASK] Convert AbstractUserAuthentication unit test to functional

Nikita Hovratov CR +2 V +2 Normal +19 −88 updated 11/19/22, 08:26

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Nikita Hovratov uploaded patch set 1 11/18/22, 14:59

  2. core-ci voted on patch set 1 V +1 11/18/22, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33921

  3. Oliver Klee commented on patch set 1 11/18/22, 16:04

    AbstractUserAuthenticationTest.php:82

    For better readability, please let's have blank lines between the setup, the execution and the assertion blocks. For details, please have a look at this slide: https://speakerdeck.com/oliverklee/test-driven-development-with-phpunit-1?slide=26

    AbstractUserAuthenticationTest.php:85

    Please let's be as strict as possible with the assertions in tests: assertEquals -> assertSame
  4. Nikita Hovratov uploaded patch set 2 11/18/22, 16:51

  5. Nikita Hovratov commented on patch set 2 11/18/22, 16:52

    AbstractUserAuthenticationTest.php:82 Reply

    Done

    AbstractUserAuthenticationTest.php:85 Reply

    Done
  6. core-ci voted on patch set 2 V +1 11/18/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33928

  7. Oliver Klee voted on patch set 2 V +1 CR +1 11/18/22, 17:05

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 11/19/22, 08:26

  9. Christian Kuhn merged patch set 3 11/19/22, 08:26