76694[TASK] Convert AbstractUserAuthentication unit test to functional
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 2
Review log 79
-
Nikita Hovratov uploaded patch set 1 11/18/22, 14:59
-
core-ci voted on patch set 1 V +1 11/18/22, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33921
-
Oliver Klee commented on patch set 1 11/18/22, 16:04
AbstractUserAuthenticationTest.php:85Please let's be as strict as possible with the assertions in tests: assertEquals -> assertSame -
Nikita Hovratov uploaded patch set 2 11/18/22, 16:51
-
Nikita Hovratov commented on patch set 2 11/18/22, 16:52
AbstractUserAuthenticationTest.php:82ReplyDoneAbstractUserAuthenticationTest.php:85ReplyDone -
core-ci voted on patch set 2 V +1 11/18/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33928
-
Oliver Klee voted on patch set 2 V +1 CR +1 11/18/22, 17:05
-
Christian Kuhn voted on patch set 2 V +2 CR +2 11/19/22, 08:26
-
Christian Kuhn merged patch set 3 11/19/22, 08:26
AbstractUserAuthenticationTest.php:82