Review main Merged

76695[TASK] Replace prophecy in EXT:core AuthenticationServiceTest

Nikita Hovratov CR +2 V +2 Normal +49 −37 updated 11/19/22, 08:24

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Nikita Hovratov uploaded patch set 1 11/18/22, 15:32

  2. Nikita Hovratov uploaded patch set 2 11/18/22, 15:39

  3. core-ci voted on patch set 1 V -1 11/18/22, 15:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33924

  4. core-ci voted on patch set 2 V +1 11/18/22, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33925

  5. Oliver Klee commented on patch set 2 CR -1 11/18/22, 16:00

    AuthenticationServiceTest.php:102

    In general, tests should not use random data as this will make the tests less reproducible. In this case, a fixed string will work just fine. Ditto in the other tests.
  6. Nikita Hovratov uploaded patch set 3 11/18/22, 16:38

  7. Nikita Hovratov commented on patch set 3 11/18/22, 16:39

    AuthenticationServiceTest.php:102 Reply

    Done
  8. core-ci voted on patch set 3 V +1 11/18/22, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33927

  9. Oliver Klee voted on patch set 3 V +1 CR +1 11/18/22, 17:03

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 11/19/22, 08:24

  11. Christian Kuhn merged patch set 4 11/19/22, 08:24