76696[TASK] Replace prophecy in EXT:core ResolverTest
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Nikita Hovratov uploaded patch set 1 11/18/22, 15:49
-
core-ci voted on patch set 1 V +1 11/18/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33926
-
Oliver Klee commented on patch set 1 V +1 CR +1 11/18/22, 16:02
-
Nikita Hovratov commented on patch set 1 11/18/22, 16:43
ResolverTest.php:39ReplyDo you mean a GU::purgeInstances() call or what do you mean by "corresponding makeInstance call" ? -
Oliver Klee commented on patch set 1 11/18/22, 17:04
ResolverTest.php:39ReplyOh, right, I totally missed that GU::purgeInstances can also drop the non-singleton instances. Then indeed it should be GU::purgeInstances, not GU::makeInstance. -
Nikita Hovratov uploaded patch set 2 11/18/22, 17:26
-
Nikita Hovratov commented on patch set 2 11/18/22, 17:27
ResolverTest.php:39ReplyDone -
core-ci voted on patch set 2 V +1 11/18/22, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33930
-
Oliver Klee voted on patch set 2 V +1 CR +1 11/18/22, 17:49
-
Christian Kuhn voted on patch set 2 V +2 CR +2 11/19/22, 08:29
-
Christian Kuhn merged patch set 3 11/19/22, 08:29
ResolverTest.php:39