Review main Merged

76696[TASK] Replace prophecy in EXT:core ResolverTest

Nikita Hovratov CR +2 V +2 Normal +23 −44 updated 11/19/22, 08:29

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Nikita Hovratov uploaded patch set 1 11/18/22, 15:49

  2. core-ci voted on patch set 1 V +1 11/18/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33926

  3. Oliver Klee commented on patch set 1 V +1 CR +1 11/18/22, 16:02

    ResolverTest.php:39

    We'll also need to have the corresponding makeInstance call in tearDown so any left-over instances won't spill over into the next test. (We can also do this as a separate bugfix. I'd be fine either way.)
  4. Nikita Hovratov commented on patch set 1 11/18/22, 16:43

    ResolverTest.php:39 Reply

    Do you mean a GU::purgeInstances() call or what do you mean by "corresponding makeInstance call" ?
  5. Oliver Klee commented on patch set 1 11/18/22, 17:04

    ResolverTest.php:39 Reply

    Oh, right, I totally missed that GU::purgeInstances can also drop the non-singleton instances. Then indeed it should be GU::purgeInstances, not GU::makeInstance.
  6. Nikita Hovratov uploaded patch set 2 11/18/22, 17:26

  7. Nikita Hovratov commented on patch set 2 11/18/22, 17:27

    ResolverTest.php:39 Reply

    Done
  8. core-ci voted on patch set 2 V +1 11/18/22, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33930

  9. Oliver Klee voted on patch set 2 V +1 CR +1 11/18/22, 17:49

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 11/19/22, 08:29

  11. Christian Kuhn merged patch set 3 11/19/22, 08:29