Review main Merged

76698[TASK] Improve type annotations for GU::locationHeaderUrl

Oliver Klee CR +2 V +2 Easy +1 −1 updated 11/19/22, 15:47

Commit message

This helps PHPStan better analyse code that uses this method.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Klee uploaded patch set 1 11/18/22, 22:36

  2. core-ci voted on patch set 1 V +1 11/18/22, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33934

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 11/19/22, 08:32

  4. Nikita Hovratov voted on patch set 1 CR +2 11/19/22, 15:46

  5. Nikita Hovratov voted on patch set 1 V +2 11/19/22, 15:46

  6. Nikita Hovratov merged patch set 2 11/19/22, 15:47