Review main Merged

76700[TASK] Improve type annotations in Extbase\Annotation classes

Oliver Klee CR +2 V +2 Easy +5 −5 updated 11/19/22, 15:52

Commit message

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Oliver Klee uploaded patch set 1 11/19/22, 09:30

  2. core-ci voted on patch set 1 V +1 11/19/22, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33942

  3. Christian Kuhn commented on patch set 1 11/19/22, 11:02

    IgnoreValidation.php:28

    |null , right?
  4. Oliver Klee commented on patch set 1 11/19/22, 11:27

    IgnoreValidation.php:28 Reply

    Done
  5. Oliver Klee uploaded patch set 2 11/19/22, 11:27

  6. Oliver Klee rebased onto patch set 3 11/19/22, 13:09

  7. core-ci voted on patch set 3 V +1 11/19/22, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33955

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 11/19/22, 15:52

  9. Nikita Hovratov voted on patch set 3 V +1 CR +1 11/19/22, 15:52

  10. Nikita Hovratov voted on patch set 3 V +2 CR +2 11/19/22, 15:52

  11. Nikita Hovratov merged patch set 4 11/19/22, 15:52