Review main Merged

76704[TASK] Modernize ext:adminpanel

Christian Kuhn CR +2 V +2 Hard +110 −234 updated 11/19/22, 15:42

Commit message

* Use more DI
* Avoid MainController being a singleton, have it DI shared
* Avoid static state in InMemoryLogWriter
* Add various type hints
* Streamline annotations
* Avoid a useless exception class
* Use inject* method for DI in an abstract class to avoid
  polluting __construct() for consumers.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 26

Show 6 more files

Review log 1115

  1. Christian Kuhn uploaded patch set 1 11/19/22, 10:48

  2. Christian Kuhn uploaded patch set 2 11/19/22, 10:51

  3. core-ci voted on patch set 1 V +1 11/19/22, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33947

  4. core-ci voted on patch set 2 V +1 11/19/22, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33948

  5. Stefan Bürk commented on patch set 2 CR -1 11/19/22, 11:53

    AdminPanelInitiatorTest.php:118

    This expect line should be moved above, directly after the $request mock line (L113). Not relatet to this test, but this late expect is useles. If a "initialize()" call is added between 117/118 the test stays green. Moved the expect above it fails. So either we should remove it move it up to make some sense ;)
  6. Stefan Bürk uploaded patch set 3 11/19/22, 12:06

  7. Christian Kuhn commented on patch set 3 11/19/22, 12:11

    AdminPanelInitiatorTest.php:118 Reply

    good catch. thx.
  8. core-ci voted on patch set 3 V +1 11/19/22, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33952

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 11/19/22, 12:22

  10. Christian Kuhn uploaded patch set 4 11/19/22, 15:30

  11. Nikita Hovratov voted on patch set 4 V +1 CR +1 11/19/22, 15:31

  12. Stefan Bürk voted on patch set 4 V +1 CR +1 11/19/22, 15:31

  13. core-ci voted on patch set 4 V +1 11/19/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33957

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 11/19/22, 15:42

  15. Christian Kuhn merged patch set 5 11/19/22, 15:42