76704[TASK] Modernize ext:adminpanel
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 26
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/adminpanel/Classes/Controller/AjaxController.php+4 −9
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+10 −22
- typo3/sysext/adminpanel/Classes/Exceptions/InvalidConfigurationException.phpdeleted+0 −25
- typo3/sysext/adminpanel/Classes/Log/DoctrineSqlLogger.php+8 −25
- typo3/sysext/adminpanel/Classes/Log/InMemoryLogWriter.php+22 −18
- typo3/sysext/adminpanel/Classes/Middleware/SqlLogging.php+3 −8
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractModule.php+11 −23
- typo3/sysext/adminpanel/Classes/ModuleApi/AbstractSubModule.php+2 −2
- typo3/sysext/adminpanel/Classes/ModuleApi/ModuleData.php+1 −1
- typo3/sysext/adminpanel/Classes/ModuleApi/ModuleDataStorageCollection.php+1 −4
- typo3/sysext/adminpanel/Classes/Modules/Debug/Log.php+5 −6
- typo3/sysext/adminpanel/Classes/Modules/Debug/PageTitle.php+3 −2
- typo3/sysext/adminpanel/Classes/Modules/TsDebug/TypoScriptWaterfall.php+3 −5
- typo3/sysext/adminpanel/Classes/Modules/DebugModule.php+3 −1
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+2 −1
- typo3/sysext/adminpanel/Classes/Service/ConfigurationService.php+1 −4
- typo3/sysext/adminpanel/Classes/Service/ModuleLoader.php+2 −3
- typo3/sysext/adminpanel/Configuration/Services.yaml+19 −0
- typo3/sysext/adminpanel/Tests/Unit/Fixtures/MainModuleFixture.php+0 −23
Show 6 more files
- typo3/sysext/adminpanel/Tests/Unit/Fixtures/SubModuleFixture.php+0 −16
- typo3/sysext/adminpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php2+5 −9
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php+2 −3
- typo3/sysext/adminpanel/Tests/Unit/Service/ConfigurationServiceTest.php+0 −5
- typo3/sysext/adminpanel/Tests/Unit/Service/ModuleLoaderTest.php+3 −6
- typo3/sysext/adminpanel/Tests/Unit/Utility/StateUtilityTest.php+0 −8
Review log 1115
-
Christian Kuhn uploaded patch set 1 11/19/22, 10:48
-
Christian Kuhn uploaded patch set 2 11/19/22, 10:51
-
core-ci voted on patch set 1 V +1 11/19/22, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33947
-
core-ci voted on patch set 2 V +1 11/19/22, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33948
-
Stefan Bürk commented on patch set 2 CR -1 11/19/22, 11:53
-
Stefan Bürk uploaded patch set 3 11/19/22, 12:06
-
Christian Kuhn commented on patch set 3 11/19/22, 12:11
AdminPanelInitiatorTest.php:118Replygood catch. thx. -
core-ci voted on patch set 3 V +1 11/19/22, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33952
-
Stefan Bürk voted on patch set 3 V +1 CR +1 11/19/22, 12:22
-
Christian Kuhn uploaded patch set 4 11/19/22, 15:30
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 11/19/22, 15:31
-
Stefan Bürk voted on patch set 4 V +1 CR +1 11/19/22, 15:31
-
core-ci voted on patch set 4 V +1 11/19/22, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33957
-
Christian Kuhn voted on patch set 4 V +2 CR +2 11/19/22, 15:42
-
Christian Kuhn merged patch set 5 11/19/22, 15:42
AdminPanelInitiatorTest.php:118